Re: [PATCH 10/15] __d_add(): don't drop/regain ->d_lock

2016-04-24 Thread Al Viro
On Sun, Apr 24, 2016 at 02:09:09PM -0400, Jeff Layton wrote: > Should the above be a new __d_instantiate_locked instead of open-coding > it? Nope - it gets rehash mashed into it a few commits later. In principle we could try to fish the common helper out of it and __d_instantiate() once the dus

Re: [PATCH 10/15] __d_add(): don't drop/regain ->d_lock

2016-04-24 Thread Jeff Layton
On Sat, 2016-04-16 at 01:55 +0100, Al Viro wrote: > From: Al Viro > > Signed-off-by: Al Viro > --- >  fs/dcache.c | 14 +++--- >  1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/fs/dcache.c b/fs/dcache.c > index e9de4d9..33cad8a 100644 > --- a/fs/dcache.c > +++ b/fs/dca

[PATCH 10/15] __d_add(): don't drop/regain ->d_lock

2016-04-15 Thread Al Viro
From: Al Viro Signed-off-by: Al Viro --- fs/dcache.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index e9de4d9..33cad8a 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2363,11 +2363,19 @@ EXPORT_SYMBOL(d_rehash); static inline