Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-21 Thread Wanlong Gao
On 02/21/2013 05:41 PM, Jason Wang wrote: > On 02/21/2013 04:30 PM, Wanlong Gao wrote: >> On 02/19/2013 03:56 PM, Rusty Russell wrote: >>> It's a bit cleaner to hand multiple sgs, rather than one big one. >>> >>> Signed-off-by: Rusty Russell >>> --- >>> drivers/net/virtio_net.c | 50 >>> ++

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-21 Thread Jason Wang
On 02/21/2013 04:30 PM, Wanlong Gao wrote: > On 02/19/2013 03:56 PM, Rusty Russell wrote: >> It's a bit cleaner to hand multiple sgs, rather than one big one. >> >> Signed-off-by: Rusty Russell >> --- >> drivers/net/virtio_net.c | 50 >> ++ >> 1 file

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-21 Thread Wanlong Gao
On 02/19/2013 03:56 PM, Rusty Russell wrote: > It's a bit cleaner to hand multiple sgs, rather than one big one. > > Signed-off-by: Rusty Russell > --- > drivers/net/virtio_net.c | 50 > ++ > 1 file changed, 24 insertions(+), 26 deletions(-) > > di

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-20 Thread Rusty Russell
Wanlong Gao writes: > On 02/19/2013 03:56 PM, Rusty Russell wrote: >> It's a bit cleaner to hand multiple sgs, rather than one big one. >> >> Signed-off-by: Rusty Russell ... >> +BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)); >> >> -ctrl.class = class; >> -ctrl.cmd =

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-20 Thread Wanlong Gao
On 02/19/2013 03:56 PM, Rusty Russell wrote: > It's a bit cleaner to hand multiple sgs, rather than one big one. > > Signed-off-by: Rusty Russell > --- > drivers/net/virtio_net.c | 50 > ++ > 1 file changed, 24 insertions(+), 26 deletions(-) > > di

[PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

2013-02-19 Thread Rusty Russell
It's a bit cleaner to hand multiple sgs, rather than one big one. Signed-off-by: Rusty Russell --- drivers/net/virtio_net.c | 50 ++ 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c i