Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Peter Griffin
Hi Mark, On Tue, 26 Apr 2016, Mark Brown wrote: > On Tue, Apr 26, 2016 at 05:14:32PM +0100, Peter Griffin wrote: > > On Tue, 26 Apr 2016, Mark Brown wrote: > > > > A lot of this is details of the system integration for this SoC, not > > > actual errors. > > > This particular clock patch yes, bu

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Mark Brown
On Tue, Apr 26, 2016 at 05:14:32PM +0100, Peter Griffin wrote: > On Tue, 26 Apr 2016, Mark Brown wrote: > > A lot of this is details of the system integration for this SoC, not > > actual errors. > This particular clock patch yes, but the other ASoC dt doc update is fixing > bindings which haven'

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Peter Griffin
Hi Mark, On Tue, 26 Apr 2016, Mark Brown wrote: > On Tue, Apr 26, 2016 at 03:51:29PM +0100, Peter Griffin wrote: > > On Tue, 26 Apr 2016, Mark Brown wrote: > > > On Tue, Apr 26, 2016 at 12:52:10PM +0100, Peter Griffin wrote: > > > > If there are never going to be any new users why bother at all,

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Mark Brown
On Tue, Apr 26, 2016 at 03:51:29PM +0100, Peter Griffin wrote: > On Tue, 26 Apr 2016, Mark Brown wrote: > > On Tue, Apr 26, 2016 at 12:52:10PM +0100, Peter Griffin wrote: > > If there are never going to be any new users why bother at all, why > > would anyone paste it in when all the SoCs that eve

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Peter Griffin
Hi Mark, On Tue, 26 Apr 2016, Mark Brown wrote: > On Tue, Apr 26, 2016 at 12:52:10PM +0100, Peter Griffin wrote: > > On Thu, 21 Apr 2016, Mark Brown wrote: > > > > This one is more relevant though I'm still a bit concerned that there's > > > an expectation that the examples can just be pasted in

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Mark Brown
On Tue, Apr 26, 2016 at 12:52:10PM +0100, Peter Griffin wrote: > On Thu, 21 Apr 2016, Mark Brown wrote: > > This one is more relevant though I'm still a bit concerned that there's > > an expectation that the examples can just be pasted in... > So although I would only consider copying an example

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-26 Thread Peter Griffin
Hi Mark, On Thu, 21 Apr 2016, Mark Brown wrote: > On Thu, Apr 21, 2016 at 12:04:27PM +0100, Peter Griffin wrote: > > > clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 2

Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-21 Thread Mark Brown
On Thu, Apr 21, 2016 at 12:04:27PM +0100, Peter Griffin wrote: > clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > + assigned-clock-parents = <&clk_s_d0_quadfs 2>; > + assigned-clock-rates = <5000>;

[PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

2016-04-21 Thread Peter Griffin
Update the examples, as otherwise driver errors with an incorrect mclk ratio at runtime. Signed-off-by: Peter Griffin Cc: arnaud.pouliq...@st.com --- Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/