Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-06-01 Thread Google
On Fri, 31 May 2024 18:49:10 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 23:50:23 +0900 > Masami Hiramatsu (Google) wrote: > > > So is it similar to the fprobe/kprobe, use shared signle ftrace_ops, > > but keep each fgraph has own hash table? > > Sort of. > > I created helper functions

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-06-01 Thread Steven Rostedt
On Fri, 31 May 2024 18:49:10 -0400 Steven Rostedt wrote: > I'm just cleaning it up. I'll post it tomorrow (your today). It's going to take a little longer. I found that the rewrite broke updating the filters while tracing is enabled. Working on fixing that now. -- Steve

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-31 Thread Steven Rostedt
On Fri, 31 May 2024 23:50:23 +0900 Masami Hiramatsu (Google) wrote: > So is it similar to the fprobe/kprobe, use shared signle ftrace_ops, > but keep each fgraph has own hash table? Sort of. I created helper functions in ftrace that lets you have a "manager ftrace_ops" that will be used to

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-31 Thread Google
On Fri, 31 May 2024 02:03:46 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 12:12:41 +0900 > Masami Hiramatsu (Google) wrote: > > > On Thu, 30 May 2024 22:30:57 -0400 > > Steven Rostedt wrote: > > > > > On Fri, 24 May 2024 22:37:02 -0400 > > > Steven Rostedt wrote: > > > > > > > From:

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-31 Thread Steven Rostedt
On Fri, 31 May 2024 12:12:41 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 30 May 2024 22:30:57 -0400 > Steven Rostedt wrote: > > > On Fri, 24 May 2024 22:37:02 -0400 > > Steven Rostedt wrote: > > > > > From: "Steven Rostedt (VMware)" > > > > > > Allow for instances to have their own

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-30 Thread Google
On Thu, 30 May 2024 22:30:57 -0400 Steven Rostedt wrote: > On Fri, 24 May 2024 22:37:02 -0400 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > Allow for instances to have their own ftrace_ops part of the fgraph_ops > > that makes the funtion_graph tracer filter on the

Re: [PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-30 Thread Steven Rostedt
On Fri, 24 May 2024 22:37:02 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow for instances to have their own ftrace_ops part of the fgraph_ops > that makes the funtion_graph tracer filter on the set_ftrace_filter file > of the instance and not the top instance. > >

[PATCH 10/20] function_graph: Have the instances use their own ftrace_ops for filtering

2024-05-24 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Allow for instances to have their own ftrace_ops part of the fgraph_ops that makes the funtion_graph tracer filter on the set_ftrace_filter file of the instance and not the top instance. Note that this also requires to update ftrace_graph_func() to call new