Re: [PATCH 10/23] gpio: mockup: fix resource leak in error path

2020-09-07 Thread Bartosz Golaszewski
On Fri, Sep 4, 2020 at 7:00 PM Andy Shevchenko wrote: > > On Fri, Sep 04, 2020 at 05:45:34PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > If the module init function fails after creating the debugs directory, > > it's never removed. Add proper cleanup calls to avoid thi

Re: [PATCH 10/23] gpio: mockup: fix resource leak in error path

2020-09-07 Thread Andy Shevchenko
On Mon, Sep 07, 2020 at 01:04:59PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 7:00 PM Andy Shevchenko > wrote: > > On Fri, Sep 04, 2020 at 05:45:34PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > If the module init function fails after creating the

Re: [PATCH 10/23] gpio: mockup: fix resource leak in error path

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 04, 2020 at 05:45:34PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > If the module init function fails after creating the debugs directory, > it's never removed. Add proper cleanup calls to avoid this resource > leak. Does it fix existing bug? > Signed-off-by: Ba

[PATCH 10/23] gpio: mockup: fix resource leak in error path

2020-09-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski If the module init function fails after creating the debugs directory, it's never removed. Add proper cleanup calls to avoid this resource leak. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri