Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Fri, Mar 1, 2013 at 12:21 AM, Erik Gilling wrote: > On Thu, Feb 28, 2013 at 7:59 PM, John Stultz wrote: >> Given its the sync driver, its most obvious choice, but I agree its likely >> to collide with filesystem related or other sync_ named functions that don't >> have a subsystem prefix. >>

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Fri, Mar 1, 2013 at 5:55 AM, Greg KH wrote: > On Fri, Mar 01, 2013 at 12:21:24AM -0800, Erik Gilling wrote: >> As John pointed out, the exynos and msm display and code uses them. I >> know nvidia is working on adding suport to their tegra tree. My knee >> jerk reaction is to make the export

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Greg KH
On Fri, Mar 01, 2013 at 12:21:24AM -0800, Erik Gilling wrote: > On Thu, Feb 28, 2013 at 7:59 PM, John Stultz wrote: > >> Also, EXPORT_SYMBOL_GPL() perhaps? > >> > >> And who is using these exports? > > > > > > From some quick git grepping... > > As John pointed out, the exynos and msm display

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Thu, Feb 28, 2013 at 7:59 PM, John Stultz wrote: >>> +EXPORT_SYMBOL(sync_timeline_create); >> >> As these are now global, should they be a bit more "specific"? "sync_" >> seems pretty broad. > > > Given its the sync driver, its most obvious choice, but I agree its likely > to collide with

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Thu, Feb 28, 2013 at 7:59 PM, John Stultz john.stu...@linaro.org wrote: +EXPORT_SYMBOL(sync_timeline_create); As these are now global, should they be a bit more specific? sync_ seems pretty broad. Given its the sync driver, its most obvious choice, but I agree its likely to collide

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Greg KH
On Fri, Mar 01, 2013 at 12:21:24AM -0800, Erik Gilling wrote: On Thu, Feb 28, 2013 at 7:59 PM, John Stultz john.stu...@linaro.org wrote: Also, EXPORT_SYMBOL_GPL() perhaps? And who is using these exports? From some quick git grepping... As John pointed out, the exynos and msm

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Fri, Mar 1, 2013 at 5:55 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Mar 01, 2013 at 12:21:24AM -0800, Erik Gilling wrote: As John pointed out, the exynos and msm display and code uses them. I know nvidia is working on adding suport to their tegra tree. My knee jerk reaction is

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-03-01 Thread Erik Gilling
On Fri, Mar 1, 2013 at 12:21 AM, Erik Gilling konk...@android.com wrote: On Thu, Feb 28, 2013 at 7:59 PM, John Stultz john.stu...@linaro.org wrote: Given its the sync driver, its most obvious choice, but I agree its likely to collide with filesystem related or other sync_ named functions that

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread John Stultz
On 02/28/2013 06:00 PM, Greg KH wrote: On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote: From: Erik Gilling This is needed to allow modules to link against the sync subsystem Cc: Maarten Lankhorst Cc: Erik Gilling Cc: Daniel Vetter Cc: Rob Clark Cc: Sumit Semwal Cc: Greg KH

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread Greg KH
On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote: > From: Erik Gilling > > This is needed to allow modules to link against the sync subsystem > > Cc: Maarten Lankhorst > Cc: Erik Gilling > Cc: Daniel Vetter > Cc: Rob Clark > Cc: Sumit Semwal > Cc: Greg KH > Cc:

[PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread John Stultz
From: Erik Gilling This is needed to allow modules to link against the sync subsystem Cc: Maarten Lankhorst Cc: Erik Gilling Cc: Daniel Vetter Cc: Rob Clark Cc: Sumit Semwal Cc: Greg KH Cc: dri-de...@lists.freedesktop.org Cc: Android Kernel Team Signed-off-by: Erik Gilling

[PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread John Stultz
From: Erik Gilling konk...@android.com This is needed to allow modules to link against the sync subsystem Cc: Maarten Lankhorst maarten.lankho...@canonical.com Cc: Erik Gilling konk...@android.com Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: Rob Clark robcl...@gmail.com Cc: Sumit Semwal

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread Greg KH
On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote: From: Erik Gilling konk...@android.com This is needed to allow modules to link against the sync subsystem Cc: Maarten Lankhorst maarten.lankho...@canonical.com Cc: Erik Gilling konk...@android.com Cc: Daniel Vetter

Re: [PATCH 10/30] staging: sync: Export sync API symbols

2013-02-28 Thread John Stultz
On 02/28/2013 06:00 PM, Greg KH wrote: On Thu, Feb 28, 2013 at 04:43:06PM -0800, John Stultz wrote: From: Erik Gilling konk...@android.com This is needed to allow modules to link against the sync subsystem Cc: Maarten Lankhorst maarten.lankho...@canonical.com Cc: Erik Gilling