Re: [PATCH 11/11] KVM/MMU: Flush tlb in the kvm_age_rmapp()

2019-01-08 Thread Paolo Bonzini
On 08/01/19 04:42, Tianyu Lan wrote: > From my understanding, this means to move the flush in the > kvm_mmu_notifier_clear_flush_young() > to kvm_age_hva() and do flush in kvm_age_hva() when young is >0 and "flush" > parameter is true, right? Yes. Paolo

Re: [PATCH 11/11] KVM/MMU: Flush tlb in the kvm_age_rmapp()

2019-01-07 Thread Tianyu Lan
Hi Paolo: Thanks for your review. On Tue, Jan 8, 2019 at 12:31 AM Paolo Bonzini wrote: > > On 07/01/19 04:42, Tianyu Lan wrote: > >> I'm assuming you're > >> clearing young to avoid the flush in kvm_mmu_notifier_clear_flush_young(), > >> but keeping that flush is silly since it

Re: [PATCH 11/11] KVM/MMU: Flush tlb in the kvm_age_rmapp()

2019-01-07 Thread Paolo Bonzini
On 07/01/19 04:42, Tianyu Lan wrote: >> I'm assuming you're >> clearing young to avoid the flush in kvm_mmu_notifier_clear_flush_young(), >> but keeping that flush is silly since it will never be invoked. Just >> squash this patch with patch 10/11 so that you can remove the unnecessary >> flush

Re: [PATCH 11/11] KVM/MMU: Flush tlb in the kvm_age_rmapp()

2019-01-06 Thread Tianyu Lan
Hi Sean: Thanks for your review. On Sat, Jan 5, 2019 at 12:12 AM Sean Christopherson wrote: > > On Fri, Jan 04, 2019 at 04:54:05PM +0800, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > This patch is to flush tlb in the kvm_age_rmapp() when tlb range flush > > is

[PATCH 11/11] KVM/MMU: Flush tlb in the kvm_age_rmapp()

2019-01-04 Thread lantianyu1986
From: Lan Tianyu This patch is to flush tlb in the kvm_age_rmapp() when tlb range flush is available and flush request is true. Signed-off-by: Lan Tianyu --- arch/x86/kvm/mmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index