Re: [PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n

2020-08-20 Thread Mark Brown
On Thu, Aug 20, 2020 at 04:32:32PM +0800, Jisheng Zhang wrote: > On Thu, 20 Aug 2020 10:13:12 +0200 Fabrice Gasnier wrote: > > You could probably adopt "__maybe_unused" here ? E.g. like: > __maybe_unused also fixes the warning. I'm not sure the maintainers' > preference. > which solution do you

Re: [PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n

2020-08-20 Thread Jisheng Zhang
On Thu, 20 Aug 2020 10:13:12 +0200 Fabrice Gasnier wrote: > > > On 8/20/20 9:46 AM, Jisheng Zhang wrote: > > Fix below warning when CONFIG_OF=n: > > > > drivers/regulator/stm32-vrefbuf.c:287:34: warning: ‘stm32_vrefbuf_of_match’ > > defined but not used [-Wunused-const-variable=] > > 287 | st

Re: [PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n

2020-08-20 Thread Fabrice Gasnier
On 8/20/20 9:46 AM, Jisheng Zhang wrote: > Fix below warning when CONFIG_OF=n: > > drivers/regulator/stm32-vrefbuf.c:287:34: warning: ‘stm32_vrefbuf_of_match’ > defined but not used [-Wunused-const-variable=] > 287 | static const struct of_device_id stm32_vrefbuf_of_match[] = { > |

[PATCH 11/12] regulator: stm32-vrefbuf: Fix W=1 build warning when CONFIG_OF=n

2020-08-20 Thread Jisheng Zhang
Fix below warning when CONFIG_OF=n: drivers/regulator/stm32-vrefbuf.c:287:34: warning: ‘stm32_vrefbuf_of_match’ defined but not used [-Wunused-const-variable=] 287 | static const struct of_device_id stm32_vrefbuf_of_match[] = { | ^~ Si