Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-25 Thread Niklas Cassel
On Tue, Jul 23, 2019 at 07:26:35AM +0530, Viresh Kumar wrote: > On 19-07-19, 17:45, Niklas Cassel wrote: > > Hello Viresh, > > > > Could you please have a look at the last two patches here: > > https://git.linaro.org/people/niklas.cassel/kernel.git/log/?h=cpr-opp-hz > > There is no sane way of

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-22 Thread Viresh Kumar
On 19-07-19, 17:45, Niklas Cassel wrote: > Hello Viresh, > > Could you please have a look at the last two patches here: > https://git.linaro.org/people/niklas.cassel/kernel.git/log/?h=cpr-opp-hz There is no sane way of providing review comments with a link to the git tree :) I still had a look

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-19 Thread Niklas Cassel
On Wed, Jul 17, 2019 at 10:19:23AM +0530, Viresh Kumar wrote: > On 16-07-19, 12:53, Niklas Cassel wrote: > > Here I cheated and simply used get_cpu_device(0). > > > > Since I cheated, I used get_cpu_device(0) always, > > so even when CPU1,CPU2,CPU3 is attached, dev_pm_opp_get_opp_count(cpu0) is >

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-16 Thread Viresh Kumar
On 16-07-19, 12:53, Niklas Cassel wrote: > Here I cheated and simply used get_cpu_device(0). > > Since I cheated, I used get_cpu_device(0) always, > so even when CPU1,CPU2,CPU3 is attached, dev_pm_opp_get_opp_count(cpu0) is > still 0. > > I added a print in > [3.836533] cpr_set_performance:

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-16 Thread Niklas Cassel
On Tue, Jul 16, 2019 at 04:04:36PM +0530, Viresh Kumar wrote: > On 15-07-19, 15:24, Niklas Cassel wrote: > > This was actually my initial thought when talking to you 6+ months ago. > > However, the problem was that, from the CPR drivers' perspective, it > > only sees the CPR OPP table. > > > > >

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-16 Thread Viresh Kumar
On 15-07-19, 15:24, Niklas Cassel wrote: > This was actually my initial thought when talking to you 6+ months ago. > However, the problem was that, from the CPR drivers' perspective, it > only sees the CPR OPP table. > > > So this is the order things are called, > from qcom-cpufreq-nvmem.c

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-15 Thread Niklas Cassel
On Wed, Jul 10, 2019 at 02:33:03PM +0530, Viresh Kumar wrote: > On 05-07-19, 11:57, Niklas Cassel wrote: > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi > > b/arch/arm64/boot/dts/qcom/qcs404.dtsi > > cpu_opp_table: cpu-opp-table { > > - compatible = "operating-points-v2"; > >

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-10 Thread Viresh Kumar
On 05-07-19, 11:57, Niklas Cassel wrote: > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi > b/arch/arm64/boot/dts/qcom/qcs404.dtsi > cpu_opp_table: cpu-opp-table { > - compatible = "operating-points-v2"; > + compatible = "operating-points-v2-kryo-cpu"; >

[PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-05 Thread Niklas Cassel
Add CPR and populate OPP table. Co-developed-by: Jorge Ramirez-Ortiz Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Niklas Cassel --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 145 +-- 1 file changed, 137 insertions(+), 8 deletions(-) diff --git