Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-11-04 Thread Namhyung Kim
On Mon, 4 Nov 2013 17:09:14 +0100, Oleg Nesterov wrote: > See my replies to 0/13. Lets assume that you agree that get_user_vaddr() > doesn't need tu->inode. Okay. > > On 10/29, Namhyung Kim wrote: >> >> This argument is for passing private data structure to each fetch >> function and will be

Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-11-04 Thread Oleg Nesterov
See my replies to 0/13. Lets assume that you agree that get_user_vaddr() doesn't need tu->inode. On 10/29, Namhyung Kim wrote: > > This argument is for passing private data structure to each fetch > function and will be used by uprobes. In this case, why do we need this "void *priv"? It actually

Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-11-04 Thread Namhyung Kim
On Mon, 4 Nov 2013 17:09:14 +0100, Oleg Nesterov wrote: See my replies to 0/13. Lets assume that you agree that get_user_vaddr() doesn't need tu-inode. Okay. On 10/29, Namhyung Kim wrote: This argument is for passing private data structure to each fetch function and will be used by

Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-11-04 Thread Oleg Nesterov
See my replies to 0/13. Lets assume that you agree that get_user_vaddr() doesn't need tu-inode. On 10/29, Namhyung Kim wrote: This argument is for passing private data structure to each fetch function and will be used by uprobes. In this case, why do we need this void *priv? It actually

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-10-29 Thread Namhyung Kim
From: Namhyung Kim This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu Cc: Srikar Dronamraju Cc: Oleg Nesterov Cc: zhangwei(Jovi) Cc: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim ---

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-10-29 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Cc: Oleg Nesterov o...@redhat.com Cc:

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-09-02 Thread Namhyung Kim
From: Namhyung Kim This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu Cc: Srikar Dronamraju Cc: Oleg Nesterov Cc: zhangwei(Jovi) Cc: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim ---

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-09-02 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Cc: Oleg Nesterov o...@redhat.com Cc:

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-27 Thread Namhyung Kim
From: Namhyung Kim This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu Cc: Srikar Dronamraju Cc: Oleg Nesterov Cc: zhangwei(Jovi) Cc: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim ---

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-27 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com This argument is for passing private data structure to each fetch function and will be used by uprobes. Acked-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Cc: Oleg Nesterov o...@redhat.com Cc:

Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-09 Thread Masami Hiramatsu
(2013/08/09 17:45), Namhyung Kim wrote: > From: Namhyung Kim > > This argument is for passing private data structure to each fetch > function and will be used by uprobes. OK, I just concern about overhead, but yeah, these fetch functions are not optimized yet. that's another story. :) I'd

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-09 Thread Namhyung Kim
From: Namhyung Kim This argument is for passing private data structure to each fetch function and will be used by uprobes. Cc: Masami Hiramatsu Cc: Srikar Dronamraju Cc: Oleg Nesterov Cc: zhangwei(Jovi) Cc: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim ---

[PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-09 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com This argument is for passing private data structure to each fetch function and will be used by uprobes. Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com Cc: Srikar Dronamraju sri...@linux.vnet.ibm.com Cc: Oleg Nesterov o...@redhat.com Cc:

Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions

2013-08-09 Thread Masami Hiramatsu
(2013/08/09 17:45), Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com This argument is for passing private data structure to each fetch function and will be used by uprobes. OK, I just concern about overhead, but yeah, these fetch functions are not optimized yet. that's another