Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-31 Thread Tejun Heo
Hello, Trond. On Wed, Jan 30, 2013 at 02:18:06AM +, Myklebust, Trond wrote: > My worry is more about Tejun's comment that we did actually need a call > to idr_remove_all() in the original code. Do we need to queue up a fix > for the 3.8 and existing stable kernels? IIUC, the only case where i

Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-29 Thread Myklebust, Trond
On Tue, 2013-01-29 at 17:58 -0500, J. Bruce Fields wrote: > On Fri, Jan 25, 2013 at 05:31:09PM -0800, Tejun Heo wrote: > > idr_destroy() can destroy idr by itself and idr_remove_all() is being > > deprecated. Drop reference to idr_remove_all(). Note that the code > > wasn't completely correct bef

Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-29 Thread J. Bruce Fields
On Fri, Jan 25, 2013 at 05:31:09PM -0800, Tejun Heo wrote: > idr_destroy() can destroy idr by itself and idr_remove_all() is being > deprecated. Drop reference to idr_remove_all(). Note that the code > wasn't completely correct before because idr_remove() on all entries > doesn't necessarily rele

[PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-25 Thread Tejun Heo
idr_destroy() can destroy idr by itself and idr_remove_all() is being deprecated. Drop reference to idr_remove_all(). Note that the code wasn't completely correct before because idr_remove() on all entries doesn't necessarily release all idr_layers which could lead to memory leak. Signed-off-by: