Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-20 Thread Sascha Hauer
On Tue, May 19, 2015 at 05:05:29PM +0300, Mikko Perttunen wrote: > On 05/19/15 16:58, Sascha Hauer wrote: > >On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: > >>Hi Mikko, > >> > >>On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > + for (i = 0; i < tz->trips; i++)

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-19 Thread Mikko Perttunen
On 05/19/15 16:58, Sascha Hauer wrote: On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: Hi Mikko, On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: + for (i = 0; i < tz->trips; i++) { + int trip_low; + + tz->ops->get_trip_temp(tz, i

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-19 Thread Sascha Hauer
On Mon, May 18, 2015 at 11:44:33AM -0700, Brian Norris wrote: > On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: > > On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > > > One interesting thing I noticed was that at least the bang-bang > > > governor only acts if the te

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-19 Thread Sascha Hauer
On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: > Hi Mikko, > > On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > > > + for (i = 0; i < tz->trips; i++) { > > > + int trip_low; > > > + > > > + tz->ops->get_trip_temp(tz, i, &trip_temp); > > > +

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-19 Thread Mikko Perttunen
On 05/18/15 23:28, Brian Norris wrote: On Mon, May 18, 2015 at 10:13:46PM +0300, Mikko Perttunen wrote: On 05/18/2015 09:44 PM, Brian Norris wrote: On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: One interesting th

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-18 Thread Brian Norris
On Mon, May 18, 2015 at 10:13:46PM +0300, Mikko Perttunen wrote: > On 05/18/2015 09:44 PM, Brian Norris wrote: > >On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: > >>On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > >>>One interesting thing I noticed was that at least

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-18 Thread Mikko Perttunen
On 05/18/2015 09:44 PM, Brian Norris wrote: On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: One interesting thing I noticed was that at least the bang-bang governor only acts if the temperature is properly smaller th

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-18 Thread Brian Norris
On Mon, May 18, 2015 at 02:09:44PM +0200, Sascha Hauer wrote: > On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > > One interesting thing I noticed was that at least the bang-bang > > governor only acts if the temperature is properly smaller than (trip > > temp - hysteresis). So pe

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-18 Thread Sascha Hauer
Hi Mikko, On Mon, May 18, 2015 at 12:06:50PM +0300, Mikko Perttunen wrote: > > + for (i = 0; i < tz->trips; i++) { > > + int trip_low; > > + > > + tz->ops->get_trip_temp(tz, i, &trip_temp); > > + tz->ops->get_trip_hyst(tz, i, &hysteresis); > > + > > + trip

Re: [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-18 Thread Mikko Perttunen
Thanks for picking up this patch :) Sorry for being late with these, but here's a few comments.. On 05/13/2015 11:52 AM, Sascha Hauer wrote: > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip

[PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points

2015-05-13 Thread Sascha Hauer
This adds support for hardware-tracked trip points to the device tree thermal sensor framework. The framework supports an arbitrary number of trip points. Whenever the current temperature is updated, the trip points immediately below and above the current temperature are found. A .set_trips callba