Re: [PATCH 11/16] media: i2c: max9286: Cache channel amplitude

2021-02-21 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:41PM +0100, Jacopo Mondi wrote: > Cache the current channel amplitude in a driver variable > to skip updating it if the new requested value is the same > as the currently configured one. > > Signed-off-by: Jacopo Mondi

Re: [PATCH 11/16] media: i2c: max9286: Cache channel amplitude

2021-02-18 Thread Kieran Bingham
On 16/02/2021 17:41, Jacopo Mondi wrote: > Cache the current channel amplitude in a driver variable > to skip updating it if the new requested value is the same > as the currently configured one. > > Signed-off-by: Jacopo Mondi I like this model better than deciding outside of the call :-)

Re: [PATCH 11/16] media: i2c: max9286: Cache channel amplitude

2021-02-17 Thread Geert Uytterhoeven
On Tue, Feb 16, 2021 at 6:41 PM Jacopo Mondi wrote: > Cache the current channel amplitude in a driver variable > to skip updating it if the new requested value is the same newly > as the currently configured one. > > Signed-off-by: Jacopo Mondi Gr{oetje,eeting}s,

[PATCH 11/16] media: i2c: max9286: Cache channel amplitude

2021-02-16 Thread Jacopo Mondi
Cache the current channel amplitude in a driver variable to skip updating it if the new requested value is the same as the currently configured one. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git