Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Tue, Feb 20, 2018 at 8:59 PM, Masahiro Yamada wrote: > > IMO, I prefer to use different names for different purpose. > So, 'stdout' and 'success' look good to me. > > BTW, I noticed just one built-in function is enough > because 'success' can be derived from

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Tue, Feb 20, 2018 at 8:59 PM, Masahiro Yamada wrote: > > IMO, I prefer to use different names for different purpose. > So, 'stdout' and 'success' look good to me. > > BTW, I noticed just one built-in function is enough > because 'success' can be derived from 'stdout'. > > So, my plan is,

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Wed, Feb 21, 2018 at 01:59:59PM +0900, Masahiro Yamada wrote: > 2018-02-20 3:01 GMT+09:00 Linus Torvalds : > > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > > wrote: > >> > >> I do like your "success"/"stdout" more than

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Wed, Feb 21, 2018 at 01:59:59PM +0900, Masahiro Yamada wrote: > 2018-02-20 3:01 GMT+09:00 Linus Torvalds : > > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > > wrote: > >> > >> I do like your "success"/"stdout" more than "shell"/"shell-stdout", > >> because with that naming I don't get the

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

2018-02-20 3:01 GMT+09:00 Linus Torvalds : > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: >> >> I do like your "success"/"stdout" more than "shell"/"shell-stdout", >> because with that naming I don't get the feeling that

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

2018-02-20 3:01 GMT+09:00 Linus Torvalds : > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: >> >> I do like your "success"/"stdout" more than "shell"/"shell-stdout", >> because with that naming I don't get the feeling that one should >> subsume the other. > > Hmm. Thinking about it some

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 10:01:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: > > > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > > because with that naming I don't get the feeling that one

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 10:01:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: > > > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > > because with that naming I don't get the feeling that one should > > subsume the other. > >

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds wrote: > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > because with that naming I don't get the feeling that one should > subsume the other. Hmm. Thinking about it some more, I really would

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds wrote: > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > because with that naming I don't get the feeling that one should > subsume the other. Hmm. Thinking about it some more, I really would prefer just "$(shell ...)"

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Sun, Feb 18, 2018 at 8:48 PM, Ulf Magnusson wrote: > On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: >> >> Can we *please* make "shell-stdout" go away, and make this just be "shell"? >> >> The rule would be very simple: >> >> - if the result of the shell

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Sun, Feb 18, 2018 at 8:48 PM, Ulf Magnusson wrote: > On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: >> >> Can we *please* make "shell-stdout" go away, and make this just be "shell"? >> >> The rule would be very simple: >> >> - if the result of the shell command is a failure,

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: > On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada > wrote: > > This is the second built-in function, which retrieves the first line > > of stdout from the given shell command. > > This is the only

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: > On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada > wrote: > > This is the second built-in function, which retrieves the first line > > of stdout from the given shell command. > > This is the only part I really don't much like in

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada wrote: > This is the second built-in function, which retrieves the first line > of stdout from the given shell command. This is the only part I really don't much like in your patch series. Most of it is just lovely

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada wrote: > This is the second built-in function, which retrieves the first line > of stdout from the given shell command. This is the only part I really don't much like in your patch series. Most of it is just lovely and looks very nice and

[PATCH 11/23] kconfig: add 'shell-stdout' function

This is the second built-in function, which retrieves the first line of stdout from the given shell command. Example code: config CC_IS_GCC bool default $(shell $CC --version | grep -q gcc) config GCC_VERSION int default $(shell-stdout

[PATCH 11/23] kconfig: add 'shell-stdout' function

This is the second built-in function, which retrieves the first line of stdout from the given shell command. Example code: config CC_IS_GCC bool default $(shell $CC --version | grep -q gcc) config GCC_VERSION int default $(shell-stdout