Re: [PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-06 Thread Joerg Roedel
Hi Brian, On Mon, Mar 05, 2018 at 11:41:01AM -0500, Brian Gerst wrote: > We can keep the same process as the existing debug/NMI handlers - > leave the current exception pt_regs on the entry stack and just switch > to the task stack for the call to the handler. Then switch back to > the entry stac

Re: [PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-05 Thread Brian Gerst
On Mon, Mar 5, 2018 at 1:25 PM, Joerg Roedel wrote: > Hi Brian, > > thanks for your review and helpful input. > > On Mon, Mar 05, 2018 at 11:41:01AM -0500, Brian Gerst wrote: >> On Mon, Mar 5, 2018 at 5:25 AM, Joerg Roedel wrote: >> > +.Lentry_from_kernel_\@: >> > + >> > + /* >> > +

Re: [PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-05 Thread Joerg Roedel
Hi Brian, thanks for your review and helpful input. On Mon, Mar 05, 2018 at 11:41:01AM -0500, Brian Gerst wrote: > On Mon, Mar 5, 2018 at 5:25 AM, Joerg Roedel wrote: > > +.Lentry_from_kernel_\@: > > + > > + /* > > +* This handles the case when we enter the kernel from > > +

Re: [PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-05 Thread Brian Gerst
On Mon, Mar 5, 2018 at 5:25 AM, Joerg Roedel wrote: > From: Joerg Roedel > > It can happen that we enter the kernel from kernel-mode and > on the entry-stack. The most common way this happens is when > we get an exception while loading the user-space segment > registers on the kernel-to-userspace

[PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-05 Thread Joerg Roedel
From: Joerg Roedel It can happen that we enter the kernel from kernel-mode and on the entry-stack. The most common way this happens is when we get an exception while loading the user-space segment registers on the kernel-to-userspace exit path. The segment loading needs to be done after the entr