Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 4:14 PM, Grant Likely wrote: > On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz wrote: >> On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely >> wrote: >>> I think you need some description in the commit text about why the type >>> of chunksize is changing. It's not clear why you'r

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Grant Likely
On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz wrote: > On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely > wrote: >> I think you need some description in the commit text about why the type >> of chunksize is changing. It's not clear why you're making this change. >> It is a bug fix? > > The type was c

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely wrote: > On Fri, 9 Aug 2013 16:26:13 -0700, Roy Franz wrote: >> EFI calls can made directly on ARM, so the function pointers >> are directly invoked. This allows types to be checked at >> compile time, so here we ensure that the parameters match >>

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Grant Likely
On Fri, 9 Aug 2013 16:26:13 -0700, Roy Franz wrote: > EFI calls can made directly on ARM, so the function pointers > are directly invoked. This allows types to be checked at > compile time, so here we ensure that the parameters match > the function signature. > > Signed-off-by: Roy Franz > ---

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-13 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: > EFI calls can made directly on ARM, so the function pointers > are directly invoked. This allows types to be checked at > compile time, so here we ensure that the parameters match > the function signature. > > Signed-off-by: Roy Franz > ---

[PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-09 Thread Roy Franz
EFI calls can made directly on ARM, so the function pointers are directly invoked. This allows types to be checked at compile time, so here we ensure that the parameters match the function signature. Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 15 +-- 1 f