Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Manivannan Sadhasivam
Hi Daniel, On Tue, Nov 20, 2018 at 11:32:52AM +0100, Daniel Lezcano wrote: > > Hi Manivannan, > > > On 19/11/2018 18:09, Manivannan Sadhasivam wrote: > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > and HWTIMER. > > As it is a new driver, can you elaborate the log and

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Manivannan Sadhasivam
Hi Daniel, On Tue, Nov 20, 2018 at 11:32:52AM +0100, Daniel Lezcano wrote: > > Hi Manivannan, > > > On 19/11/2018 18:09, Manivannan Sadhasivam wrote: > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > and HWTIMER. > > As it is a new driver, can you elaborate the log and

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Manivannan Sadhasivam
On Tue, Nov 20, 2018 at 11:05:41AM +, Marc Zyngier wrote: > On 20/11/2018 08:56, Linus Walleij wrote: > > On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > > > >> How does this change anything with the fact that the above code is > >> broken? 56 or 64 bit, you cannot read this counter

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Manivannan Sadhasivam
On Tue, Nov 20, 2018 at 11:05:41AM +, Marc Zyngier wrote: > On 20/11/2018 08:56, Linus Walleij wrote: > > On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > > > >> How does this change anything with the fact that the above code is > >> broken? 56 or 64 bit, you cannot read this counter

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On 20/11/2018 08:56, Linus Walleij wrote: > On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > >> How does this change anything with the fact that the above code is >> broken? 56 or 64 bit, you cannot read this counter with a single >> access, or two. The canonical way of reading such a

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On 20/11/2018 08:56, Linus Walleij wrote: > On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > >> How does this change anything with the fact that the above code is >> broken? 56 or 64 bit, you cannot read this counter with a single >> access, or two. The canonical way of reading such a

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Daniel Lezcano
Hi Manivannan, On 19/11/2018 18:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. As it is a new driver, can you elaborate the log and describe the timer. > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Daniel Lezcano
Hi Manivannan, On 19/11/2018 18:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. As it is a new driver, can you elaborate the log and describe the timer. > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Linus Walleij
On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > How does this change anything with the fact that the above code is > broken? 56 or 64 bit, you cannot read this counter with a single > access, or two. The canonical way of reading such a counter is > something like this: > > do { >

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Linus Walleij
On Tue, Nov 20, 2018 at 9:17 AM Marc Zyngier wrote: > How does this change anything with the fact that the above code is > broken? 56 or 64 bit, you cannot read this counter with a single > access, or two. The canonical way of reading such a counter is > something like this: > > do { >

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On Tue, 20 Nov 2018 05:06:50 +, Manivannan Sadhasivam wrote: > > Hi Marc, > > On Mon, Nov 19, 2018 at 05:57:12PM +, Marc Zyngier wrote: > > On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > > and HWTIMER. > > > >

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-20 Thread Marc Zyngier
On Tue, 20 Nov 2018 05:06:50 +, Manivannan Sadhasivam wrote: > > Hi Marc, > > On Mon, Nov 19, 2018 at 05:57:12PM +, Marc Zyngier wrote: > > On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > > and HWTIMER. > > > >

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Manivannan Sadhasivam
Hi Marc, On Mon, Nov 19, 2018 at 05:57:12PM +, Marc Zyngier wrote: > On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > and HWTIMER. > > > > Signed-off-by: Andreas Färber > > Signed-off-by: Manivannan Sadhasivam > > ---

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Manivannan Sadhasivam
Hi Marc, On Mon, Nov 19, 2018 at 05:57:12PM +, Marc Zyngier wrote: > On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > > and HWTIMER. > > > > Signed-off-by: Andreas Färber > > Signed-off-by: Manivannan Sadhasivam > > ---

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Marc Zyngier
On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. > > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/mach-rda/Kconfig | 1 + > drivers/clocksource/Kconfig | 7

Re: [PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Marc Zyngier
On 19/11/2018 17:09, Manivannan Sadhasivam wrote: > Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER > and HWTIMER. > > Signed-off-by: Andreas Färber > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/mach-rda/Kconfig | 1 + > drivers/clocksource/Kconfig | 7

[PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Manivannan Sadhasivam
Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER and HWTIMER. Signed-off-by: Andreas Färber Signed-off-by: Manivannan Sadhasivam --- arch/arm/mach-rda/Kconfig | 1 + drivers/clocksource/Kconfig | 7 ++ drivers/clocksource/Makefile| 1 +

[PATCH 12/16] clocksource: Add clock driver for RDA8810PL SoC

2018-11-19 Thread Manivannan Sadhasivam
Add clock driver for RDA Micro RDA8810PL SoC supporting OSTIMER and HWTIMER. Signed-off-by: Andreas Färber Signed-off-by: Manivannan Sadhasivam --- arch/arm/mach-rda/Kconfig | 1 + drivers/clocksource/Kconfig | 7 ++ drivers/clocksource/Makefile| 1 +