[PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-25 Thread Christoph Hellwig
Always build mm/gup.c so that we don't have to provide separate nommu stubs. Also merge the get_user_pages_fast and __get_user_pages_fast stubs when HAVE_FAST_GUP into the main implementations, which will never call the fast path if HAVE_FAST_GUP is not set. This also ensures the new put_user_pag

Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-06 Thread John Hubbard
On 6/5/19 11:20 PM, Christoph Hellwig wrote: On Wed, Jun 05, 2019 at 11:01:17PM -0700, John Hubbard wrote: I started reviewing this one patch, and it's kind of messy figuring out if the code motion preserves everything because of all the consolidation from other places, plus having to move thing

Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-05 Thread Christoph Hellwig
On Wed, Jun 05, 2019 at 11:01:17PM -0700, John Hubbard wrote: > I started reviewing this one patch, and it's kind of messy figuring out > if the code motion preserves everything because of > all the consolidation from other places, plus having to move things in > and out of the ifdef blocks. So I

Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-05 Thread John Hubbard
On 6/1/19 12:49 AM, Christoph Hellwig wrote: > Always build mm/gup.c, and move the nommu versions and replace the > separate stubs for various functions by the default ones, with the _fast > version always falling back to the slow path because gup_fast_permitted > always returns false now if HAVE_F

[PATCH 12/16] mm: consolidate the get_user_pages* implementations

2019-06-01 Thread Christoph Hellwig
Always build mm/gup.c, and move the nommu versions and replace the separate stubs for various functions by the default ones, with the _fast version always falling back to the slow path because gup_fast_permitted always returns false now if HAVE_FAST_GUP is not set, and we use the nommu version of _