Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-20 Thread Christoph Hellwig
On Mon, May 20, 2019 at 09:55:42AM -0500, Alex Elder wrote: > On 5/20/19 9:50 AM, Arnd Bergmann wrote: > > Ok, that sounds reasonable, yes. I'm not sure if > > dma_alloc_coherent() guarantees zero-initialization > > though, so if that is required, you may have to > > add a memset(). > I had

Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-20 Thread Alex Elder
On 5/20/19 9:50 AM, Arnd Bergmann wrote: > Ok, that sounds reasonable, yes. I'm not sure if > dma_alloc_coherent() guarantees zero-initialization > though, so if that is required, you may have to > add a memset(). I had dma_zalloc_coherent() originally but I think Christoph Hellwig posted

Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-20 Thread Arnd Bergmann
On Sat, May 18, 2019 at 2:34 AM Alex Elder wrote: > On 5/15/19 7:35 AM, Alex Elder wrote: > > On 5/15/19 3:16 AM, Arnd Bergmann wrote: > >> > >> This looks rather strange. I think I looked at it before and you explained > >> it, but I have since forgotten what you do it for, so I assume everyone

Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-17 Thread Alex Elder
On 5/15/19 7:35 AM, Alex Elder wrote: > On 5/15/19 3:16 AM, Arnd Bergmann wrote: >> On Sun, May 12, 2019 at 3:25 AM Alex Elder wrote: >> >>> +/* Initialize header space in IPA local memory */ >>> +int ipa_cmd_hdr_init_local(struct ipa *ipa, u32 offset, u32 size) >>> +{ >>> + struct

Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-15 Thread Alex Elder
On 5/15/19 3:16 AM, Arnd Bergmann wrote: > On Sun, May 12, 2019 at 3:25 AM Alex Elder wrote: > >> +/* Initialize header space in IPA local memory */ >> +int ipa_cmd_hdr_init_local(struct ipa *ipa, u32 offset, u32 size) >> +{ >> + struct ipa_imm_cmd_hw_hdr_init_local *payload; >> +

Re: [PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-15 Thread Arnd Bergmann
On Sun, May 12, 2019 at 3:25 AM Alex Elder wrote: > +/* Initialize header space in IPA local memory */ > +int ipa_cmd_hdr_init_local(struct ipa *ipa, u32 offset, u32 size) > +{ > + struct ipa_imm_cmd_hw_hdr_init_local *payload; > + struct device *dev = >pdev->dev; > +

[PATCH 12/18] soc: qcom: ipa: immediate commands

2019-05-11 Thread Alex Elder
One TX endpoint (per EE) is used for issuing immediate commands to the IPA. These commands request activites beyond simple data transfers to be done by the IPA hardware. For example, the IPA is able to manage routing packets among endpoints, and immediate commands are used to configure tables