Re: [PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_changed instead of check_disk_change and > call idecd_revalidate_disk manually. Given that idecd_revalidate_disk > only re-reads the TOC, and we already do the same at probe time, the > extra call into ->revalidate_disk

[PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-08 Thread Christoph Hellwig
Switch to use bdev_check_media_changed instead of check_disk_change and call idecd_revalidate_disk manually. Given that idecd_revalidate_disk only re-reads the TOC, and we already do the same at probe time, the extra call into ->revalidate_disk from bdev_disk_changed is not required either, so

Re: [PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-02 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

[PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-02 Thread Christoph Hellwig
Switch to use bdev_check_media_changed instead of check_disk_change and call idecd_revalidate_disk manually. Given that idecd_revalidate_disk only re-reads the TOC, and we already do the same at probe time, the extra call into ->revalidate_disk from bdev_disk_changed is not required either, so