Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-06 Thread Dan Carpenter
On Mon, Dec 05, 2016 at 07:10:45PM -0500, Brian Masney wrote: > On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote: > > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > > > Fixed warning found by make W=2 to reduce the amount of build noise: > > > > > > warning:

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-06 Thread Dan Carpenter
On Mon, Dec 05, 2016 at 07:10:45PM -0500, Brian Masney wrote: > On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote: > > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > > > Fixed warning found by make W=2 to reduce the amount of build noise: > > > > > > warning:

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-05 Thread Brian Masney
On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote: > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > > Fixed warning found by make W=2 to reduce the amount of build noise: > > > > warning: comparison between signed and unsigned integer expressions > > [-Wsign-compare]

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-05 Thread Brian Masney
On Mon, Dec 05, 2016 at 11:53:39PM +0300, Dan Carpenter wrote: > On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > > Fixed warning found by make W=2 to reduce the amount of build noise: > > > > warning: comparison between signed and unsigned integer expressions > > [-Wsign-compare]

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-05 Thread Dan Carpenter
On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > Fixed warning found by make W=2 to reduce the amount of build noise: > > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] Ugh... Please don't do work arounds for nonsense warnings. W=2 is so

Re: [PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-05 Thread Dan Carpenter
On Sat, Dec 03, 2016 at 09:19:36PM -0500, Brian Masney wrote: > Fixed warning found by make W=2 to reduce the amount of build noise: > > warning: comparison between signed and unsigned integer expressions > [-Wsign-compare] Ugh... Please don't do work arounds for nonsense warnings. W=2 is so

[PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-03 Thread Brian Masney
Fixed warning found by make W=2 to reduce the amount of build noise: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-03 Thread Brian Masney
Fixed warning found by make W=2 to reduce the amount of build noise: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git