Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-09 Thread Glauber Costa
On 04/09/2013 07:46 AM, Kamezawa Hiroyuki wrote: > (2013/04/09 12:18), Li Zefan wrote: @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup *cont, struct cftype *cft, struct seq_file *m) { struct

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-09 Thread Glauber Costa
On 04/09/2013 07:18 AM, Li Zefan wrote: >>> @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup >>> *cont, struct cftype *cft, >>> struct seq_file *m) >>> { >>> struct mem_cgroup *memcg; >>> + char *memcg_name; >>> + int ret; >>>

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Tejun Heo
On Tue, Apr 09, 2013 at 11:18:21AM +0800, Li Zefan wrote: > >> - if (memcg->memcg_name) > >> - seq_printf(m, "%s:\n", memcg->memcg_name); > >> + ret = cgroup_path(memcg->css.cgroup, memcg_name, PAGE_SIZE); > >> + if (!ret) > >> + seq_prin

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Kamezawa Hiroyuki
(2013/04/09 12:18), Li Zefan wrote: >>> @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup >>> *cont, struct cftype *cft, >>> struct seq_file *m) >>>{ >>> struct mem_cgroup *memcg; >>> + char *memcg_name; >>> + int ret; >>> + >

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Li Zefan
>> @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup >> *cont, struct cftype *cft, >> struct seq_file *m) >> { >> struct mem_cgroup *memcg; >> +char *memcg_name; >> +int ret; >> + >> +/* >> + * cgroup.c will do pag

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Kamezawa Hiroyuki
(2013/04/08 15:36), Li Zefan wrote: > Now memcg has the same life cycle as its corresponding cgroup, > we don't have to save the cgroup path name in memcg->memcg_name. > > Signed-off-by: Li Zefan > --- > mm/memcontrol.c | 65 > + > 1 fil

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Li Zefan
On 2013/4/8 22:25, Michal Hocko wrote: > On Mon 08-04-13 14:36:52, Li Zefan wrote: > [...] >> @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup >> *cont, struct cftype *cft, >> struct seq_file *m) >> { >> struct mem_cgroup *memcg;

Re: [PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-08 Thread Michal Hocko
On Mon 08-04-13 14:36:52, Li Zefan wrote: [...] > @@ -5188,12 +5154,28 @@ static int mem_cgroup_dangling_read(struct cgroup > *cont, struct cftype *cft, > struct seq_file *m) > { > struct mem_cgroup *memcg; > + char *memcg_name; > + int ret; Th

[PATCH 13/12] memcg: don't need memcg->memcg_name

2013-04-07 Thread Li Zefan
Now memcg has the same life cycle as its corresponding cgroup, we don't have to save the cgroup path name in memcg->memcg_name. Signed-off-by: Li Zefan --- mm/memcontrol.c | 65 + 1 file changed, 24 insertions(+), 41 deletions(-) diff --gi