RE: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

2016-07-21 Thread Bounine, Alexandre
> -Original Message- > From: Andrew Morton [mailto:a...@linux-foundation.org] > Sent: Thursday, July 21, 2016 2:37 PM > To: Bounine, Alexandre > Cc: Matt Porter; Andre van Herk; Wood, Barry; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 13/13] rapidio/switche

Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

2016-07-21 Thread Andrew Morton
On Thu, 21 Jul 2016 18:48:17 + "Bounine, Alexandre" wrote: > > > + udelay(10); > > > + rio_write_config_32(rdev, RIO_PLM_SPx_IMP_SPEC_CTL(pnum), > > rval); > > > + mdelay(500); > > > > Yikes, that's a very long busywait. A half-second machine freeze on > > uniproces

Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

2016-07-21 Thread Andrew Morton
On Thu, 21 Jul 2016 14:18:54 -0400 Alexandre Bounine wrote: > Add RapidIO switch driver for IDT Gen3 switch devices: RXS1632 and RXS2448. > > ... > > +static int > +idtg3_em_handler(struct rio_dev *rdev, u8 pnum) > +{ > + u32 err_status; > + u32 rval; > + > + rio_read_config_32(rdev

[PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

2016-07-21 Thread Alexandre Bounine
Add RapidIO switch driver for IDT Gen3 switch devices: RXS1632 and RXS2448. Signed-off-by: Alexandre Bounine Tested-by: Barry Wood Cc: Matt Porter Cc: Andre van Herk Cc: Barry Wood Cc: linux-kernel@vger.kernel.org --- drivers/rapidio/switches/Kconfig|6 + drivers/rapidio/switches/Mak