Re: [PATCH 13/13 v4] perf tools: add thread field

2020-11-17 Thread James Clark
On 15/11/2020 23:17, Jiri Olsa wrote: > On Fri, Nov 13, 2020 at 07:26:54PM +0200, James Clark wrote: >> A separate field isn't strictly required. The core >> field could be re-used for thread IDs as a single >> field was used previously. >> >> But separating them will avoid confusion and catch >

Re: [PATCH 13/13 v4] perf tools: add thread field

2020-11-15 Thread Jiri Olsa
On Fri, Nov 13, 2020 at 07:26:54PM +0200, James Clark wrote: > A separate field isn't strictly required. The core > field could be re-used for thread IDs as a single > field was used previously. > > But separating them will avoid confusion and catch > potential errors where core IDs are read as th

[PATCH 13/13 v4] perf tools: add thread field

2020-11-13 Thread James Clark
A separate field isn't strictly required. The core field could be re-used for thread IDs as a single field was used previously. But separating them will avoid confusion and catch potential errors where core IDs are read as thread IDs and vice versa. Also remove the placeholder id field which is n