Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-13 Thread Nicholas A. Bellinger
On Sun, 2014-01-12 at 13:53 +0200, Sagi Grimberg wrote: > > > >> I wander how we can skip sbc_dif_verify_ if the transport already > >> offloaded DIF verify. > >> I think that the transport should signal the core layer that it is able > >> to offload DIF (ADD/STRIP/PASS/VERIFY), in which cas

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 11:06 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: Sagi> I wander how we can skip sbc_dif_verify_ if the transport Sagi> already offloaded DIF verify. I think that the transport should Sagi> signal the core layer that it is able to offload DIF Sagi> (ADD/STRIP

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-12 Thread Sagi Grimberg
I wander how we can skip sbc_dif_verify_ if the transport already offloaded DIF verify. I think that the transport should signal the core layer that it is able to offload DIF (ADD/STRIP/PASS/VERIFY), in which case the core should turn off the backstore DIF verify emulation to sustain perfo

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-10 Thread Martin K. Petersen
> "Sagi" == Sagi Grimberg writes: Sagi> I wander how we can skip sbc_dif_verify_ if the transport Sagi> already offloaded DIF verify. I think that the transport should Sagi> signal the core layer that it is able to offload DIF Sagi> (ADD/STRIP/PASS/VERIFY), in which case the core should

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-09 Thread Nicholas A. Bellinger
On Thu, 2014-01-09 at 12:32 +0200, Sagi Grimberg wrote: > On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds support for DIF protection into rd_execute_rw() code > > for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. > > > > It also a

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-09 Thread Sagi Grimberg
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds support for DIF protection into rd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It also adds rd_get_prot_table() for locating protection SGLs assoicated with the ramdi

[PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-08 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF protection into rd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It also adds rd_get_prot_table() for locating protection SGLs assoicated with the ramdisk backend device. Cc: Martin K. Petersen Cc: Chris