Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-17 Thread Namhyung Kim
Hi Arnaldo, On Tue, 17 Dec 2013 17:02:39 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 17, 2013 at 09:02:36AM +0900, Namhyung Kim escreveu: >> On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: >> > Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: >> >> On

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-17 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 17, 2013 at 09:02:36AM +0900, Namhyung Kim escreveu: > On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: > >> On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: > >> > All the rest

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-17 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 17, 2013 at 09:02:36AM +0900, Namhyung Kim escreveu: On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: All the rest is ok, so

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-17 Thread Namhyung Kim
Hi Arnaldo, On Tue, 17 Dec 2013 17:02:39 -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 17, 2013 at 09:02:36AM +0900, Namhyung Kim escreveu: On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: On Fri, 13

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-16 Thread Namhyung Kim
Hi Arnaldo, On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: >> On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: >> > All the rest is ok, so its just the malloc + strcpy that remains to be >>

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: > On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: > > All the rest is ok, so its just the malloc + strcpy that remains to be > > converted, do you want me to do it? > Hmm.. did you mean like this? >

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: All the rest is ok, so its just the malloc + strcpy that remains to be converted, do you want me to do it? Hmm.. did you mean like this? str

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-16 Thread Namhyung Kim
Hi Arnaldo, On Mon, 16 Dec 2013 09:40:51 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 16, 2013 at 01:49:11PM +0900, Namhyung Kim escreveu: On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: All the rest is ok, so its just the malloc + strcpy that remains to be

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-15 Thread Namhyung Kim
Hi Arnaldo, On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: >> -str = malloc_or_die(6); >> +str = malloc(6); >> +if (str == NULL) >> +break; >>

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-15 Thread Namhyung Kim
Hi Arnaldo, On Fri, 13 Dec 2013 11:52:04 -0300, Arnaldo Carvalho de Melo wrote: -str = malloc_or_die(6); +str = malloc(6); +if (str == NULL) +break;

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-13 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 13, 2013 at 09:15:46AM +0900, Namhyung Kim escreveu: > Hi Arnaldo, > > On Thu, 12 Dec 2013 15:41:47 -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: > >> Those functions are for stringify filter arguments. As caller of > >>

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-13 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 13, 2013 at 09:15:46AM +0900, Namhyung Kim escreveu: Hi Arnaldo, On Thu, 12 Dec 2013 15:41:47 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: Those functions are for stringify filter arguments. As caller of those

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-12 Thread Namhyung Kim
Hi Arnaldo, On Thu, 12 Dec 2013 15:41:47 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: >> Those functions are for stringify filter arguments. As caller of >> those functions handles NULL string properly, it seems that it's >> enough to

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-12 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: > Those functions are for stringify filter arguments. As caller of > those functions handles NULL string properly, it seems that it's > enough to return NULL rather than calling die(). > > Signed-off-by: Namhyung Kim > --- >

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-12 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: Those functions are for stringify filter arguments. As caller of those functions handles NULL string properly, it seems that it's enough to return NULL rather than calling die(). Signed-off-by: Namhyung Kim namhy...@kernel.org

Re: [PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-12 Thread Namhyung Kim
Hi Arnaldo, On Thu, 12 Dec 2013 15:41:47 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 12, 2013 at 04:36:16PM +0900, Namhyung Kim escreveu: Those functions are for stringify filter arguments. As caller of those functions handles NULL string properly, it seems that it's enough to return

[PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-11 Thread Namhyung Kim
Those functions are for stringify filter arguments. As caller of those functions handles NULL string properly, it seems that it's enough to return NULL rather than calling die(). Signed-off-by: Namhyung Kim --- tools/lib/traceevent/parse-filter.c | 58 +++-- 1

[PATCH 13/14] tools lib traceevent: Get rid of die() in some string conversion funcitons

2013-12-11 Thread Namhyung Kim
Those functions are for stringify filter arguments. As caller of those functions handles NULL string properly, it seems that it's enough to return NULL rather than calling die(). Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/lib/traceevent/parse-filter.c | 58