Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-17 Thread Jan Engelhardt
Hi, On Wed, 04 Apr 2007 07:03:55 +0200, Eric Dumazet wrote: >find net | xargs grep -n SIOCINQ >I suspect you will find unix_ioctl() in net/unix/af_unix.c ? >BTW, my patch only worked for pipes, not fifos. Ie pipe(), not >open("/some/fifo.p", ...) Thanks for your patch. There is a question

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-17 Thread Jan Engelhardt
Hi, On Wed, 04 Apr 2007 07:03:55 +0200, Eric Dumazet wrote: find net | xargs grep -n SIOCINQ I suspect you will find unix_ioctl() in net/unix/af_unix.c ? BTW, my patch only worked for pipes, not fifos. Ie pipe(), not open(/some/fifo.p, ...) Thanks for your patch. There is a question however;

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-03 Thread Eric Dumazet
Jan Engelhardt a écrit : On Apr 2 2007 12:41, Eric Dumazet wrote: The following patch does the right thing for pipes, I let you doing the same for sockets... Is struct sock->sk_receive_queue->qlen actually the thing I am looking for? (Previously, I had struct sock->sk_rcvbuf, which was

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-03 Thread Jan Engelhardt
On Apr 2 2007 12:41, Eric Dumazet wrote: > >The following patch does the right thing for pipes, I let you doing >the same for sockets... Is struct sock->sk_receive_queue->qlen actually the thing I am looking for? (Previously, I had struct sock->sk_rcvbuf, which was obviously wrong.) Thanks, Jan

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-03 Thread Jan Engelhardt
On Apr 2 2007 12:41, Eric Dumazet wrote: The following patch does the right thing for pipes, I let you doing the same for sockets... Is struct sock-sk_receive_queue-qlen actually the thing I am looking for? (Previously, I had struct sock-sk_rcvbuf, which was obviously wrong.) Thanks, Jan -- -

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-03 Thread Eric Dumazet
Jan Engelhardt a écrit : On Apr 2 2007 12:41, Eric Dumazet wrote: The following patch does the right thing for pipes, I let you doing the same for sockets... Is struct sock-sk_receive_queue-qlen actually the thing I am looking for? (Previously, I had struct sock-sk_rcvbuf, which was obviously

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-02 Thread Eric Dumazet
On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > Show the fill status of a pipe (in bytes) when stat'ing one. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > > fs/stat.c | 31 ++- > include/linux/un.h|

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-02 Thread Jan Engelhardt
On Apr 1 2007 22:58, Andrew Morton wrote: >On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt <[EMAIL PROTECTED]> >wrote: > >> Show the fill status of a pipe (in bytes) when stat'ing one. > >Is this useful? It seems rather an obscure thing, and we generally need a >good reason to go adding

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-02 Thread Jan Engelhardt
On Apr 1 2007 22:58, Andrew Morton wrote: On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt [EMAIL PROTECTED] wrote: Show the fill status of a pipe (in bytes) when stat'ing one. Is this useful? It seems rather an obscure thing, and we generally need a good reason to go adding

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-02 Thread Eric Dumazet
On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt [EMAIL PROTECTED] wrote: Show the fill status of a pipe (in bytes) when stat'ing one. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] fs/stat.c | 31 ++- include/linux/un.h|2 ++

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-01 Thread Andrew Morton
On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > Show the fill status of a pipe (in bytes) when stat'ing one. > Is this useful? It seems rather an obscure thing, and we generally need a good reason to go adding Linux-specific goodies to standard system

[PATCH 13/16] show-pipesize-in-stat.diff

2007-04-01 Thread Jan Engelhardt
Show the fill status of a pipe (in bytes) when stat'ing one. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> fs/stat.c | 31 ++- include/linux/un.h|2 ++ include/net/af_unix.h |3 +++ net/unix/af_unix.c| 10 ++ 4 files

[PATCH 13/16] show-pipesize-in-stat.diff

2007-04-01 Thread Jan Engelhardt
Show the fill status of a pipe (in bytes) when stat'ing one. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] fs/stat.c | 31 ++- include/linux/un.h|2 ++ include/net/af_unix.h |3 +++ net/unix/af_unix.c| 10 ++ 4 files

Re: [PATCH 13/16] show-pipesize-in-stat.diff

2007-04-01 Thread Andrew Morton
On Sun, 1 Apr 2007 20:17:24 +0200 (MEST) Jan Engelhardt [EMAIL PROTECTED] wrote: Show the fill status of a pipe (in bytes) when stat'ing one. Is this useful? It seems rather an obscure thing, and we generally need a good reason to go adding Linux-specific goodies to standard system calls