Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread David Miller
From: Sudeep Holla Date: Mon, 21 Sep 2015 16:47:09 +0100 > The device is set as wakeup capable using proper wakeup API but the > driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > which is incorrect. > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread Li Yang
On Wed, Sep 23, 2015 at 5:03 PM, Thomas Gleixner wrote: > On Wed, 23 Sep 2015, Li Yang wrote: >> On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: >> > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >> >The device is set as wakeup capable using proper wakeup API but the >> >> >driver

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread Li Yang
On Wed, Sep 23, 2015 at 5:03 PM, Thomas Gleixner wrote: > On Wed, 23 Sep 2015, Li Yang wrote: >> On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: >> > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >> >The device is set as wakeup capable using

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread David Miller
From: Sudeep Holla Date: Mon, 21 Sep 2015 16:47:09 +0100 > The device is set as wakeup capable using proper wakeup API but the > driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > which is incorrect. > > This patch removes the use of IRQF_NO_SUSPEND

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-23 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Li Yang wrote: > On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: > > On Mon, 21 Sep 2015, Manoil Claudiu wrote: > >> >The device is set as wakeup capable using proper wakeup API but the > >> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > >>

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-23 Thread Li Yang
On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >The device is set as wakeup capable using proper wakeup API but the >> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >> >which is incorrect. >> > >> >This patch

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-23 Thread Thomas Gleixner
On Wed, 23 Sep 2015, Li Yang wrote: > On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: > > On Mon, 21 Sep 2015, Manoil Claudiu wrote: > >> >The device is set as wakeup capable using proper wakeup API but the > >> >driver misuses IRQF_NO_SUSPEND to set the interrupt as

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-23 Thread Li Yang
On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >The device is set as wakeup capable using proper wakeup API but the >> >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >> >which is incorrect. >> >

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-22 Thread Sudeep Holla
On 22/09/15 15:04, Manoil Claudiu wrote: -Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] [...] on PPC architectures, the flag did the job. When did this change? Since when using IRQF_NO_SUSPEND is a "misuse"? It always was. Simply because IRQF_NO_SUSPEND has

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-22 Thread Manoil Claudiu
er ; Kevin Hao ; >net...@vger.kernel.org >Subject: RE: [PATCH 13/17] net: gianfar: remove misuse of >IRQF_NO_SUSPEND flag > >On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >The device is set as wakeup capable using proper wakeup API but the >> >driver misuses IRQF_NO_SUSPEND to set

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-22 Thread Sudeep Holla
On 22/09/15 15:04, Manoil Claudiu wrote: -Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] [...] on PPC architectures, the flag did the job. When did this change? Since when using IRQF_NO_SUSPEND is a "misuse"? It always was. Simply because IRQF_NO_SUSPEND has

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-22 Thread Manoil Claudiu
.kernel.org; Rafael J. Wysocki <r...@rjwysocki.net>; David S. >Miller <da...@davemloft.net>; Kevin Hao <haoke...@gmail.com>; >net...@vger.kernel.org >Subject: RE: [PATCH 13/17] net: gianfar: remove misuse of >IRQF_NO_SUSPEND flag > >On Mon, 21 Sep 2015, Manoil C

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Manoil Claudiu
u-B08782 >; Kevin Hao ; >net...@vger.kernel.org >Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND >flag > >The device is set as wakeup capable using proper wakeup API but the >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >whic

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Thomas Gleixner
On Mon, 21 Sep 2015, Manoil Claudiu wrote: > >The device is set as wakeup capable using proper wakeup API but the > >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > >which is incorrect. > > > >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
; Manoil Claudiu-B08782 ; Kevin Hao ; net...@vger.kernel.org Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag The device is set as wakeup capable using proper wakeup API but the driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source which is incorrect

[PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
The device is set as wakeup capable using proper wakeup API but the driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source which is incorrect. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: "David S. Miller" Cc: Claudiu Manoil

[PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
The device is set as wakeup capable using proper wakeup API but the driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source which is incorrect. This patch removes the use of IRQF_NO_SUSPEND flags replacing it with enable_irq_wake instead. Cc: "David S. Miller"

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Thomas Gleixner
On Mon, 21 Sep 2015, Manoil Claudiu wrote: > >The device is set as wakeup capable using proper wakeup API but the > >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > >which is incorrect. > > > >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >

RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Manoil Claudiu
J. Wysocki <r...@rjwysocki.net>; David S. Miller ><da...@davemloft.net>; Manoil Claudiu-B08782 ><claudiu.man...@freescale.com>; Kevin Hao <haoke...@gmail.com>; >net...@vger.kernel.org >Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND &g

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-21 Thread Sudeep Holla
tronix.de>; Rafael J. Wysocki <r...@rjwysocki.net>; David S. Miller <da...@davemloft.net>; Manoil Claudiu-B08782 <claudiu.man...@freescale.com>; Kevin Hao <haoke...@gmail.com>; net...@vger.kernel.org Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPE