Hi Sakari - sorry for delayed reply. I didn't get this email actually,
just spotted it on the newsgroup by chance.
On 15/12/2020 22:02, Sakari Ailus wrote:
> Hi Daniel,
>
> On Tue, Dec 15, 2020 at 10:28:59AM +, Daniel Scally wrote:
>> Morning Sakari
>>
>> On 30/11/2020 20:35, Sakari Ailus
Hi Daniel,
On Tue, Dec 15, 2020 at 10:28:59AM +, Daniel Scally wrote:
> Morning Sakari
>
> On 30/11/2020 20:35, Sakari Ailus wrote:
> >> +/*
> >> + * Extend this array with ACPI Hardware ID's of devices known to be
> >> working.
> >> + * Do not add a HID for a sensor that is not actually
On 15/12/2020 10:28, Daniel Scally wrote:
> Morning Sakari
>
> On 30/11/2020 20:35, Sakari Ailus wrote:
>>> +/*
>>> + * Extend this array with ACPI Hardware ID's of devices known to be
>>> working.
>>> + * Do not add a HID for a sensor that is not actually supported.
>>> + */
>>> +static const
Morning Sakari
On 30/11/2020 20:35, Sakari Ailus wrote:
>> +/*
>> + * Extend this array with ACPI Hardware ID's of devices known to be working.
>> + * Do not add a HID for a sensor that is not actually supported.
>> + */
>> +static const char * const cio2_supported_devices[] = {
>> +
On 02/12/2020 12:02, Andy Shevchenko wrote:
> On Wed, Dec 02, 2020 at 10:53:05AM +, Dan Scally wrote:
>> On 02/12/2020 10:38, Sakari Ailus wrote:
>
> ...
>
> Argh, thanks, this is the curse of using VS code on multiple machines...
I recommend vim ;-)
>>> What is VS code? Very
On Wed, Dec 02, 2020 at 10:53:05AM +, Dan Scally wrote:
> On 02/12/2020 10:38, Sakari Ailus wrote:
...
> >>> Argh, thanks, this is the curse of using VS code on multiple machines...
> >> I recommend vim ;-)
> > What is VS code? Very Serious Code?
>
> Visual Studio Code - it has some nice
On Wed, Dec 02, 2020 at 12:38:51PM +0200, Sakari Ailus wrote:
> On Wed, Dec 02, 2020 at 12:30:53AM +0200, Laurent Pinchart wrote:
> > On Tue, Dec 01, 2020 at 10:08:25PM +, Dan Scally wrote:
> > > On 30/11/2020 17:09, Laurent Pinchart wrote:
> > > > On Mon, Nov 30, 2020 at 01:31:24PM +,
On 02/12/2020 10:38, Sakari Ailus wrote:
> Hi Laurent,
>
> On Wed, Dec 02, 2020 at 12:30:53AM +0200, Laurent Pinchart wrote:
>> Hi Daniel,
>>
>> On Tue, Dec 01, 2020 at 10:08:25PM +, Dan Scally wrote:
>>> On 30/11/2020 17:09, Laurent Pinchart wrote:
On Mon, Nov 30, 2020 at 01:31:24PM
Hi Laurent,
On Wed, Dec 02, 2020 at 12:30:53AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Tue, Dec 01, 2020 at 10:08:25PM +, Dan Scally wrote:
> > On 30/11/2020 17:09, Laurent Pinchart wrote:
> > > On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
> > >> Currently on
Hi Laurent
On 01/12/2020 22:30, Laurent Pinchart wrote:
+}
+
+static void cio2_bridge_create_fwnode_properties(struct cio2_sensor
*sensor)
+{
+ unsigned int i;
+
+ cio2_bridge_init_property_names(sensor);
+
+ for (i = 0; i < 4; i++)
+
Hi Daniel,
On Tue, Dec 01, 2020 at 10:08:25PM +, Dan Scally wrote:
> On 30/11/2020 17:09, Laurent Pinchart wrote:
> > On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
> >> Currently on platforms designed for Windows, connections between CIO2 and
> >> sensors are not properly
On 01/12/2020 22:08, Dan Scally wrote:
>>> +
>>> + for_each_acpi_dev_match(adev, this_device, NULL, -1) {
>>> + if (!adev || !(adev->status.present &&
>>> adev->status.enabled))
>> if (!adev || !adev->status.present ||
>> !adev->status.enabled))
Hi Laurent - thanks for reviewing
On 30/11/2020 17:09, Laurent Pinchart wrote:
> Hi Daniel,
>
> Thank you for the patch.
>
> On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
>> Currently on platforms designed for Windows, connections between CIO2 and
>> sensors are not properly
On Mon, Nov 30, 2020 at 10:35:51PM +0200, Sakari Ailus wrote:
> On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
...
> > +/*
> > + * Extend this array with ACPI Hardware ID's of devices known to be
> > working.
> > + * Do not add a HID for a sensor that is not actually supported.
Hi Sakari
On 30/11/2020 20:35, Sakari Ailus wrote:
> Hi Daniel,
>
> Thanks for the update! This is starting to look really nice!
>
> Please still see my comments below.
Thanks!
>
> On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
>> Currently on platforms designed for Windows,
Hi Daniel,
Thanks for the update! This is starting to look really nice!
Please still see my comments below.
On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
> Currently on platforms designed for Windows, connections between CIO2 and
> sensors are not properly defined in DSDT. This
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on driver-core/driver-core-testing pm/linux-next
v5.10-rc6 next-20201130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when
On Mon, Nov 30, 2020 at 07:09:55PM +0200, Laurent Pinchart wrote:
> On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
I agree with most of Laurent's comments. S
...
> > + Say Y here if your device is a detachable / hybrid laptop that comes
> > + with Windows installed by
Hi Daniel,
Thank you for the patch.
On Mon, Nov 30, 2020 at 01:31:24PM +, Daniel Scally wrote:
> Currently on platforms designed for Windows, connections between CIO2 and
> sensors are not properly defined in DSDT. This patch extends the ipu3-cio2
> driver to compensate by building
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on driver-core/driver-core-testing pm/linux-next
v5.10-rc6 next-20201130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when
Currently on platforms designed for Windows, connections between CIO2 and
sensors are not properly defined in DSDT. This patch extends the ipu3-cio2
driver to compensate by building software_node connections, parsing the
connection properties from the sensor's SSDB buffer.
Suggested-by: Jordan
21 matches
Mail list logo
