Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-29 Thread Jan Engelhardt
Hi, >Jan Engelhardt wrote: >>On Apr 28 2007 12:41, Stefan Richter wrote: >> >>> So, shall I put Jan's patch aside until there is only one stack left? >> >> Sort of. [...] when a menu has two or three choices (in this case: >> larger subsystems), it's rand() for me whether or not to convert >> to m

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-28 Thread Stefan Richter
Jan Engelhardt wrote: > On Apr 28 2007 12:41, Stefan Richter wrote: >> So, shall I put Jan's patch aside until there is only one stack left? > > Sort of. [...] > when a menu has > two or three choices (in this case: larger subsystems), it's rand() > for me whether or not to convert to menuconfig.

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-28 Thread Jan Engelhardt
On Apr 28 2007 12:41, Stefan Richter wrote: > >So, shall I put Jan's patch aside until there is only one stack left? Sort of. >Or what about: > > menuconfig FIREWIRE_SUPPORT > tristate "IEEE 1394 (FireWire) support" > > config FIREWIRE > tristate "new Fire

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-28 Thread Stefan Richter
Jan Engelhardt wrote: > On Apr 27 2007 22:56, Stefan Richter wrote: > >>> -config IEEE1394 >>> +menuconfig IEEE1394 >>> tristate "IEEE 1394 (FireWire) support" >>> depends on PCI || BROKEN >>> select NET >> [...] >> >> Unless there are objections, I will merge it into my queue of IEEE

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-28 Thread Jan Engelhardt
On Apr 27 2007 22:56, Stefan Richter wrote: >> -config IEEE1394 >> +menuconfig IEEE1394 >> tristate "IEEE 1394 (FireWire) support" >> depends on PCI || BROKEN >> select NET >[...] > >Unless there are objections, I will merge it into my queue of IEEE 1394 >updates for Linus. Yes, I

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-27 Thread Stefan Richter
Jan Engelhardt wrote on 2007-04-10: > Use menuconfigs instead of menus, so the whole menu can be disabled at > once instead of going through all options. > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > > Index: linux-2.6.21-rc5/drivers/ieee1394/Kconfig > ==

Re: [PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-10 Thread Stefan Richter
Jan Engelhardt wrote: > Use menuconfigs instead of menus, so the whole menu can be disabled at > once instead of going through all options. If you excuse the nitpicking: The patch description is not very precise. You don't have to go through all options in the IEEE 1394 menu if you don't

[PATCH 13/30] Use menuconfig objects - IEEE1394

2007-04-10 Thread Jan Engelhardt
Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: linux-2.6.21-rc5/drivers/ieee1394/Kconfig === --- lin