Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-05-07 Thread Miklos Szeredi
On Fri, Apr 26, 2013 at 7:44 PM, Maxim V. Patlasov wrote: > I'm for accounting NR_WRITEBACK_TEMP because balance_dirty_pages is already > overcomplicated (imho) and adding new clauses for FUSE makes me sick. Agreed. But instead of further complexifying balance_dirty_pages() fuse specific throttl

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-26 Thread Maxim V. Patlasov
Miklos, MM folks, 04/26/2013 06:02 PM, Miklos Szeredi пишет: On Fri, Apr 26, 2013 at 12:32:24PM +0400, Maxim V. Patlasov wrote: The idea is that fuse filesystems should not go over the bdi limit even if the global limit hasn't been reached. This might work, but kicking flusher every time some

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-26 Thread Miklos Szeredi
On Fri, Apr 26, 2013 at 12:32:24PM +0400, Maxim V. Patlasov wrote: > > The idea is that fuse filesystems should not go over the bdi limit even if > > the global limit hasn't been reached. > > This might work, but kicking flusher every time someone write to > fuse mount and dives into balance_dirt

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-26 Thread Maxim V. Patlasov
Hi Miklos, 04/26/2013 12:43 AM, Miklos Szeredi пишет: On Thu, Apr 25, 2013 at 08:16:45PM +0400, Maxim V. Patlasov wrote: As Mel Gorman pointed out, fuse daemon diving into balance_dirty_pages should not kick flusher judging on NR_WRITEBACK_TEMP. Essentially, all we need in balance_dirty_pages i

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-25 Thread Miklos Szeredi
On Thu, Apr 25, 2013 at 08:16:45PM +0400, Maxim V. Patlasov wrote: > > As Mel Gorman pointed out, fuse daemon diving into > balance_dirty_pages should not kick flusher judging on > NR_WRITEBACK_TEMP. Essentially, all we need in balance_dirty_pages > is: > > if (I'm not fuse daemon) >

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-25 Thread Maxim V. Patlasov
Hi, 04/25/2013 07:49 PM, Miklos Szeredi пишет: On Thu, Apr 25, 2013 at 4:29 PM, Maxim V. Patlasov wrote: diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0713bfb..c47bcd4 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1235,7 +1235,8 @@ static void balance_dirty_page

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-25 Thread Miklos Szeredi
On Thu, Apr 25, 2013 at 4:29 PM, Maxim V. Patlasov wrote: >> diff --git a/mm/page-writeback.c b/mm/page-writeback.c >> index 0713bfb..c47bcd4 100644 >> --- a/mm/page-writeback.c >> +++ b/mm/page-writeback.c >> @@ -1235,7 +1235,8 @@ static void balance_dirty_pages(struct address_space >> *mapping,

Re: [fuse-devel] [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-25 Thread Maxim V. Patlasov
Hi Miklos, 04/01/2013 02:42 PM, Maxim V. Patlasov пишет: Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages on fuse, thus giving the userspace part of it a chance to write stuff properly. Note, that the

[PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-04-01 Thread Maxim V. Patlasov
Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages on fuse, thus giving the userspace part of it a chance to write stuff properly. Note, that the existing balance logic is per-bdi, i.e. if the fuse user ta

[PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2013-01-25 Thread Maxim V. Patlasov
Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages on fuse, thus giving the userspace part of it a chance to write stuff properly. Note, that the existing balance logic is per-bdi, i.e. if the fuse user ta

Re: [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2012-11-22 Thread Jaegeuk Hanse
On 11/21/2012 08:01 PM, Maxim Patlasov wrote: Added linux-mm@ to cc:. The patch can stand on it's own. Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages on fuse, thus giving the userspace part of it a

Re: [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2012-11-22 Thread Maxim V. Patlasov
Hi, 11/22/2012 05:27 PM, Jaegeuk Hanse пишет: On 11/21/2012 08:01 PM, Maxim Patlasov wrote: Added linux-mm@ to cc:. The patch can stand on it's own. Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages

Re: [PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2012-11-21 Thread Maxim Patlasov
Added linux-mm@ to cc:. The patch can stand on it's own. > Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP > counter is high enough. This prevents us from having too many dirty > pages on fuse, thus giving the userspace part of it a chance to write > stuff properly. > > Note

[PATCH 14/14] mm: Account for WRITEBACK_TEMP in balance_dirty_pages

2012-11-16 Thread Maxim Patlasov
Make balance_dirty_pages start the throttling when the WRITEBACK_TEMP counter is high enough. This prevents us from having too many dirty pages on fuse, thus giving the userspace part of it a chance to write stuff properly. Note, that the existing balance logic is per-bdi, i.e. if the fuse user ta