Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former patch "ASoC: pxa:

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-05 Thread Arnd Bergmann
On Thu, Apr 5, 2018 at 8:51 AM, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> I'm still unable to follow through that code, but I understand now that >> the device you pass to dma_request_slave_channel() is not the one >> we'd like it to be here. >> >>

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-05 Thread Arnd Bergmann
On Thu, Apr 5, 2018 at 8:51 AM, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> I'm still unable to follow through that code, but I understand now that >> the device you pass to dma_request_slave_channel() is not the one >> we'd like it to be here. >> >> Where exactly does that call to

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-05 Thread Robert Jarzmik
Arnd Bergmann writes: > I'm still unable to follow through that code, but I understand now that > the device you pass to dma_request_slave_channel() is not the one > we'd like it to be here. > > Where exactly does that call to dma_request_chan() happen? Is this > the one in

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-05 Thread Robert Jarzmik
Arnd Bergmann writes: > I'm still unable to follow through that code, but I understand now that > the device you pass to dma_request_slave_channel() is not the one > we'd like it to be here. > > Where exactly does that call to dma_request_chan() happen? Is this > the one in dmaengine_pcm_new()?

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Tue, Apr 3, 2018 at 5:32 PM, Robert Jarzmik wrote: > Arnd Bergmann writes: > > chop chop ... removed several mail recipients to leave only the ASoC / PXA > subset ... > >> On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik >> wrote:

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Tue, Apr 3, 2018 at 5:32 PM, Robert Jarzmik wrote: > Arnd Bergmann writes: > > chop chop ... removed several mail recipients to leave only the ASoC / PXA > subset ... > >> On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik >> wrote: >> >>> >>> +static struct pxa_ssp_info pxa_ssp_infos[] = { >>>

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: chop chop ... removed several mail recipients to leave only the ASoC / PXA subset ... > On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > >> >> +static struct pxa_ssp_info pxa_ssp_infos[] = { >> + { .dma_chan_rx_name =

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: chop chop ... removed several mail recipients to leave only the ASoC / PXA subset ... > On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > >> >> +static struct pxa_ssp_info pxa_ssp_infos[] = { >> + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx",

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > > +static struct pxa_ssp_info pxa_ssp_infos[] = { > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + {

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > > +static struct pxa_ssp_info pxa_ssp_infos[] = { > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name =

[PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-02 Thread Robert Jarzmik
In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik

[PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-02 Thread Robert Jarzmik
In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik ---