Re: [PATCH 14/17] perf, tool: Support for dwarf cfi unwinding on post processing

2012-07-25 Thread Frederic Weisbecker
On Wed, Jul 25, 2012 at 02:16:55PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jul 25, 2012 at 07:05:33PM +0200, Frederic Weisbecker escreveu: > > > +#ifdef ARCH_X86_64 > > > +int unwind__arch_reg_id(int regnum) > > > > Please try to avoid __ in function names. We used that convention > > bef

Re: [PATCH 14/17] perf, tool: Support for dwarf cfi unwinding on post processing

2012-07-25 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 25, 2012 at 07:05:33PM +0200, Frederic Weisbecker escreveu: > > +#ifdef ARCH_X86_64 > > +int unwind__arch_reg_id(int regnum) > > Please try to avoid __ in function names. We used that convention > before but we gave up because that's actually more painful than > anything. Well, I cont

Re: [PATCH 14/17] perf, tool: Support for dwarf cfi unwinding on post processing

2012-07-25 Thread Frederic Weisbecker
On Sun, Jul 22, 2012 at 02:14:37PM +0200, Jiri Olsa wrote: > This brings the support for dwarf cfi unwinding on perf post > processing. Call frame informations are retrieved and then passed > to libunwind that requests memory and register content from the > applications. > > Adding unwind object t

[PATCH 14/17] perf, tool: Support for dwarf cfi unwinding on post processing

2012-07-22 Thread Jiri Olsa
This brings the support for dwarf cfi unwinding on perf post processing. Call frame informations are retrieved and then passed to libunwind that requests memory and register content from the applications. Adding unwind object to handle the user stack backtrace based on the user register values and