Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted

2019-10-21 Thread Ard Biesheuvel
On Tue, 22 Oct 2019 at 00:40, Sami Tolvanen wrote: > > On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel > wrote: > > You'll have to elaborate a bit here and explain that this is > > sufficient, given that we run EFI runtime services with interrupts > > enabled. > > I can add a note about this in v

Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted

2019-10-21 Thread Sami Tolvanen
On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel wrote: > You'll have to elaborate a bit here and explain that this is > sufficient, given that we run EFI runtime services with interrupts > enabled. I can add a note about this in v2. This is called with preemption disabled and we have a separate i

Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted

2019-10-20 Thread Ard Biesheuvel
On Fri, 18 Oct 2019 at 18:11, Sami Tolvanen wrote: > > If we detect a corrupted x18 and SCS is enabled, restore the register > before jumping back to instrumented code. > You'll have to elaborate a bit here and explain that this is sufficient, given that we run EFI runtime services with interrupt

[PATCH 14/18] arm64: efi: restore x18 if it was corrupted

2019-10-18 Thread Sami Tolvanen
If we detect a corrupted x18 and SCS is enabled, restore the register before jumping back to instrumented code. Signed-off-by: Sami Tolvanen --- arch/arm64/kernel/efi-rt-wrapper.S | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/efi-rt-wrapper.S b/arch