Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-28 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > > I thought about doing it in the MSI enable methods, but I think it > really belongs in the (nonexistant) routine that allocs and sets up a > pci_dev. I agree that would be a good place for it as well. > I think it's pretty dicy to be passing

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-28 Thread Michael Ellerman
On Wed, 2007-03-28 at 00:29 -0600, Eric W. Biederman wrote: > Michael Ellerman <[EMAIL PROTECTED]> writes: > > > The msi descriptors are linked together with what looks a lot like > > a linked list, but isn't a struct list_head list. Make it one. > > > > The only complication is that previously

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-28 Thread Michael Ellerman
On Wed, 2007-03-28 at 00:29 -0600, Eric W. Biederman wrote: Michael Ellerman [EMAIL PROTECTED] writes: The msi descriptors are linked together with what looks a lot like a linked list, but isn't a struct list_head list. Make it one. The only complication is that previously we walked a

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-28 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: I thought about doing it in the MSI enable methods, but I think it really belongs in the (nonexistant) routine that allocs and sets up a pci_dev. I agree that would be a good place for it as well. I think it's pretty dicy to be passing around a

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-27 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > The msi descriptors are linked together with what looks a lot like > a linked list, but isn't a struct list_head list. Make it one. > > The only complication is that previously we walked a list of irqs, and > got the descriptor for each with

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: The msi descriptors are linked together with what looks a lot like a linked list, but isn't a struct list_head list. Make it one. The only complication is that previously we walked a list of irqs, and got the descriptor for each with get_irq_msi().