Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread Aaro Koskinen
Hi, On Thu, Mar 12, 2015 at 02:04:41PM -0400, James Bottomley wrote: > On Thu, 2015-03-12 at 11:14 -0500, Scott Wood wrote: > > On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: > > > On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > > > > Use %pS for actual addresses, otherwise

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread James Bottomley
On Thu, 2015-03-12 at 11:14 -0500, Scott Wood wrote: > On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: > > On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > > > Use %pS for actual addresses, otherwise you'll get bad output > > > on arches like ppc64 where %pF expects a function

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread Scott Wood
On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: > On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. Even on > > other architectures, refrain from

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread John David Anglin
On 2015-03-12 8:11 AM, James Bottomley wrote: On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread James Bottomley
On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. Even on > other architectures, refrain from setting a bad example that people > copy. Are you sure about this?

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread John David Anglin
On 2015-03-12 8:11 AM, James Bottomley wrote: On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread Scott Wood
On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread Aaro Koskinen
Hi, On Thu, Mar 12, 2015 at 02:04:41PM -0400, James Bottomley wrote: On Thu, 2015-03-12 at 11:14 -0500, Scott Wood wrote: On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread James Bottomley
On Thu, 2015-03-12 at 11:14 -0500, Scott Wood wrote: On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote: On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor.

Re: [PATCH 14/22] parisc: %pF is only for function pointers

2015-03-12 Thread James Bottomley
On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Are you sure about this?

[PATCH 14/22] parisc: %pF is only for function pointers

2015-03-11 Thread Scott Wood
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood Cc: linux-par...@vger.kernel.org --- drivers/parisc/superio.c

[PATCH 14/22] parisc: %pF is only for function pointers

2015-03-11 Thread Scott Wood
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood scottw...@freescale.com Cc: linux-par...@vger.kernel.org ---