Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Thomas Gleixner
On Wed, 2007-01-31 at 16:15 -0800, Daniel Walker wrote: > > clocksource_initcall is simply superfluid. > > My position has always been that clocksources should be registered as > early as possible .. The fs_initcall() usage is a compromise stemming > from early resistance that John, and you gave t

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread David Brownell
On Wednesday 31 January 2007 2:47 pm, Daniel Walker wrote: > On Wed, 2007-01-31 at 11:43 -0800, David Brownell wrote: > > > As a note, arm and mips both register their clocksources during > > > time_init() instead of using initcalls. > > > > That's actually platform-specific. ... > > > > So don'

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Daniel Walker
On Thu, 2007-02-01 at 00:23 +0100, Thomas Gleixner wrote: > Daniel, > > On Wed, 2007-01-31 at 14:47 -0800, Daniel Walker wrote: > > > So don't assume any platform doesn't use clocksource initcalls. > > > > What does your OMAP clocksource do now ? I thought one of the changes > > that you made was

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Thomas Gleixner
Daniel, On Wed, 2007-01-31 at 14:47 -0800, Daniel Walker wrote: > > So don't assume any platform doesn't use clocksource initcalls. > > What does your OMAP clocksource do now ? I thought one of the changes > that you made was to have both 32k and mpu both registered .. It is up to the clocksourc

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Daniel Walker
On Wed, 2007-01-31 at 11:43 -0800, David Brownell wrote: > > As a note, arm and mips both register their clocksources during > > time_init() instead of using initcalls. > > That's actually platform-specific. If there's only one possible > clocksource, that'd be the normal answer. > > Otherwise,

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread David Brownell
> As a note, arm and mips both register their clocksources during > time_init() instead of using initcalls. That's actually platform-specific. If there's only one possible clocksource, that'd be the normal answer. Otherwise, there can be multiple clocksources just like any other architecture. M

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Thomas Gleixner
On Wed, 2007-01-31 at 09:20 -0800, Daniel Walker wrote: > The purpose of clocksource_initcall is so the initcall can be increased > without changing all the individual clocksources .. So I have to > disconnect that from the acpi_pm because it can't tolerate it. Each clocksource has to decide on it

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Daniel Walker
On Wed, 2007-01-31 at 18:10 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-01-31 at 12:50 +0100, Ingo Molnar wrote: > > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > > -module_init(init_acpi_pm_clocksource); > > > > +/* > > > > + * This clocks

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > On Wed, 2007-01-31 at 12:50 +0100, Ingo Molnar wrote: > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > -module_init(init_acpi_pm_clocksource); > > > +/* > > > + * This clocksource is removed from the clocksource_initcall > > > + * macro since

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Daniel Walker
On Wed, 2007-01-31 at 12:50 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > -module_init(init_acpi_pm_clocksource); > > +/* > > + * This clocksource is removed from the clocksource_initcall > > + * macro since it's mandatory for it to be in fs_initcall as the > > + * h

Re: [PATCH 14/23] clocksource: increase initcall priority

2007-01-31 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > -module_init(init_acpi_pm_clocksource); > +/* > + * This clocksource is removed from the clocksource_initcall > + * macro since it's mandatory for it to be in fs_initcall as the > + * highest initcall level, or else it doesn't work properly with > + *

[PATCH 14/23] clocksource: increase initcall priority

2007-01-30 Thread Daniel Walker
Normal systems often have almost everything registered in device_initcall() . Most drivers are registered there, and usually if people add code that needs an initcall they will either use device_initcall() or module_init() which both result in the same initcall.. When John created the clocksource