Re: [PATCH 15/15] riscv: add binfmt_flat support

2019-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2019 at 09:16:43AM +0100, Vladimir Murzin wrote: > On 6/10/19 10:20 PM, Christoph Hellwig wrote: > > Use the generic support with arguments are on the stack. Same as arm > > and m68k. > > Out of curiosity, what is reason for keeping arguments on the stack? > > ARM port of uClibc

Re: [PATCH 15/15] riscv: add binfmt_flat support

2019-06-11 Thread Vladimir Murzin
On 6/10/19 10:20 PM, Christoph Hellwig wrote: > Use the generic support with arguments are on the stack. Same as arm > and m68k. Out of curiosity, what is reason for keeping arguments on the stack? ARM port of uClibc has following comment around manipulating of argv/argc: /* *

[PATCH 15/15] riscv: add binfmt_flat support

2019-06-10 Thread Christoph Hellwig
Use the generic support with arguments are on the stack. Same as arm and m68k. Signed-off-by: Christoph Hellwig --- arch/riscv/Kconfig| 2 ++ arch/riscv/include/asm/Kbuild | 1 + 2 files changed, 3 insertions(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index