Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

On Sat, Jun 10, 2017 at 10:01:22AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell > wrote: > > > > > +static struct attribute *serdev_device_attrs[] = { > > ^^^ > > Should

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

On Sat, Jun 10, 2017 at 10:01:22AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell > wrote: > > > > > +static struct attribute *serdev_device_attrs[] = { > > ^^^ > > Should have been

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

Hi Greg, On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell wrote: > > > +static struct attribute *serdev_device_attrs[] = { > ^^^ > Should have been "serdev_device_groups" Sorry, my mistake. > > + _attr_modalias.attr, >

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

Hi Greg, On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell wrote: > > > +static struct attribute *serdev_device_attrs[] = { > ^^^ > Should have been "serdev_device_groups" Sorry, my mistake. > > + _attr_modalias.attr, > > + NULL, > > }; > >

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

Hi Greg, On Tue, 6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman wrote: > > -static struct device_attribute serdev_device_attrs[] = { > - __ATTR_RO(modalias), > - __ATTR_NULL > +static struct attribute *serdev_device_attrs[] = {

Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

Hi Greg, On Tue, 6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman wrote: > > -static struct device_attribute serdev_device_attrs[] = { > - __ATTR_RO(modalias), > - __ATTR_NULL > +static struct attribute *serdev_device_attrs[] = { ^^^ Should have

[PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

The dev_attrs field has long been "depreciated" and is finally being removed, so move the driver to use the "correct" dev_groups field instead for struct bus_type. Cc: Rob Herring Cc: Jiri Slaby Signed-off-by: Greg Kroah-Hartman ---

[PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

The dev_attrs field has long been "depreciated" and is finally being removed, so move the driver to use the "correct" dev_groups field instead for struct bus_type. Cc: Rob Herring Cc: Jiri Slaby Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serdev/core.c | 10 ++ 1 file changed, 6