RE: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-03 Thread Moore, Robert
; ACPI Devel Maling List a...@vger.kernel.org>; Jérémy Lefaure ; > de...@acpica.org > Subject: Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE > > On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King > wrote: > > On 03/10/17 12:39, Rafael J. Wysocki wrote: > >> On Tues

Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-03 Thread Rafael J. Wysocki
On Tue, Oct 3, 2017 at 2:34 PM, Colin Ian King wrote: > On 03/10/17 12:39, Rafael J. Wysocki wrote: >> On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: >>> On Mon, 02 Oct 2017 14:27:52 +0200 >>> "Rafael J. Wysocki" wrote: >>> ACPICA is soewhat special code, though and I'm no

Re: [Devel] [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-03 Thread Colin Ian King
On 03/10/17 12:39, Rafael J. Wysocki wrote: > On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: >> On Mon, 02 Oct 2017 14:27:52 +0200 >> "Rafael J. Wysocki" wrote: >> >>> ACPICA is soewhat special code, though and I'm not taking or ACKing patches >>> for it directly as a rule. >>>

Re: [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-03 Thread Rafael J. Wysocki
On Tuesday, October 3, 2017 3:16:22 AM CEST Jérémy Lefaure wrote: > On Mon, 02 Oct 2017 14:27:52 +0200 > "Rafael J. Wysocki" wrote: > > > ACPICA is soewhat special code, though and I'm not taking or ACKing patches > > for it directly as a rule. > > > > For one, I'm not sure if ACPICA can use ARR

Re: [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-02 Thread Jérémy Lefaure
On Mon, 02 Oct 2017 14:27:52 +0200 "Rafael J. Wysocki" wrote: > ACPICA is soewhat special code, though and I'm not taking or ACKing patches > for it directly as a rule. > > For one, I'm not sure if ACPICA can use ARRAY_SIZE at all. Why is it special code that can't use ARRAY_SIZE ? Is it because

Re: [PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-02 Thread Rafael J. Wysocki
On Sunday, October 1, 2017 9:30:53 PM CEST Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. It is > useless to re-invent the ARRAY_SIZE macro so let's use it. > > It is useless to re-invent the ARRAY_SIZE macro so let's use it. ACPICA is soewhat special cod

[PATCH 15/18] acpi: use ARRAY_SIZE

2017-10-01 Thread Jérémy Lefaure
Using the ARRAY_SIZE macro improves the readability of the code. It is useless to re-invent the ARRAY_SIZE macro so let's use it. It is useless to re-invent the ARRAY_SIZE macro so let's use it. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E;