RE: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-04-17 Thread Reshetova, Elena
> On Tue, Feb 28, 2017 at 5:11 PM, Paul Moore wrote: > > On Tue, Feb 21, 2017 at 2:15 AM, Reshetova, Elena > > wrote: > >>> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova > >>> wrote: > >>> > refcount_t type and corresponding API should be > >>> > used instead of atomic_t when the variable is

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-04-11 Thread Paul Moore
On Tue, Feb 28, 2017 at 5:11 PM, Paul Moore wrote: > On Tue, Feb 21, 2017 at 2:15 AM, Reshetova, Elena > wrote: >>> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova >>> wrote: >>> > refcount_t type and corresponding API should be >>> > used instead of atomic_t when the variable is used as >>> >

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-03-01 Thread Kees Cook
On Wed, Mar 1, 2017 at 11:35 AM, Paul Moore wrote: > On Tue, Feb 28, 2017 at 7:16 PM, Kees Cook wrote: >> On Tue, Feb 28, 2017 at 2:11 PM, Paul Moore wrote: >>> I just realized that include/linux/refcount.h didn't make it into >>> v4.10 which means there is going to be delay until I merge them i

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-03-01 Thread Paul Moore
On Tue, Feb 28, 2017 at 7:16 PM, Kees Cook wrote: > On Tue, Feb 28, 2017 at 2:11 PM, Paul Moore wrote: >> I just realized that include/linux/refcount.h didn't make it into >> v4.10 which means there is going to be delay until I merge them into >> the audit tree (I don't base the tree on -rc relea

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-03-01 Thread Paul Moore
On Tue, Feb 21, 2017 at 2:15 AM, Reshetova, Elena wrote: >> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova >> wrote: >> > refcount_t type and corresponding API should be >> > used instead of atomic_t when the variable is used as >> > a reference counter. This allows to avoid accidental >> > ref

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-02-28 Thread Kees Cook
On Tue, Feb 28, 2017 at 2:11 PM, Paul Moore wrote: > On Tue, Feb 21, 2017 at 2:15 AM, Reshetova, Elena > wrote: >>> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova >>> wrote: >>> > refcount_t type and corresponding API should be >>> > used instead of atomic_t when the variable is used as >>> >

RE: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-02-20 Thread Reshetova, Elena
> On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova > wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situatio

Re: [PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-02-20 Thread Paul Moore
On Mon, Feb 20, 2017 at 5:19 AM, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed

[PATCH 15/19] kernel: convert audit_tree.count from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-