Re: [PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys

2015-10-22 Thread Dave Hansen
On 10/22/2015 03:25 PM, Jerome Glisse wrote: > On Thu, Oct 22, 2015 at 02:23:08PM -0700, Dave Hansen wrote: ... >> Can you give an example of where a process might be doing a gup and it >> is completely separate from the CPU context that it's being executed under? > > In drivers/iommu/amd_iommu_v2

Re: [PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys

2015-10-22 Thread Jerome Glisse
On Thu, Oct 22, 2015 at 02:23:08PM -0700, Dave Hansen wrote: > On 10/22/2015 01:57 PM, Jerome Glisse wrote: > > I have not read all the patches, but here i assume that for GUP you do > > not first call arch_vma_access_permitted(). So issue i see is that GUP > > for a process might happen inside ano

Re: [PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys

2015-10-22 Thread Dave Hansen
On 10/22/2015 01:57 PM, Jerome Glisse wrote: > I have not read all the patches, but here i assume that for GUP you do > not first call arch_vma_access_permitted(). So issue i see is that GUP > for a process might happen inside another process and that process might > have different pkru protection

Re: [PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys

2015-10-22 Thread Jerome Glisse
On Mon, Sep 28, 2015 at 12:18:23PM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Today, for normal faults and page table walks, we check the VMA > and/or PTE to ensure that it is compatible with the action. For > instance, if we get a write fault on a non-writeable VMA, we > SIGSEGV. > >

[PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys

2015-09-28 Thread Dave Hansen
From: Dave Hansen Today, for normal faults and page table walks, we check the VMA and/or PTE to ensure that it is compatible with the action. For instance, if we get a write fault on a non-writeable VMA, we SIGSEGV. We try to do the same thing for protection keys. Basically, we try to make su