Re: [PATCH 15/31] mips/kvm: Exception handling to leave and reenter guest mode.

2013-10-11 Thread James Hogan
Hi David, I know it's been a while since you posted this patchset, but thought you might appreciate the feedback anyway. Some of my comments/suggestions relate to portability with MIPS32. I don't object if you respond to those by just adding "depends on 64BIT" so that I & others can fix it up in

Re: [PATCH 15/31] mips/kvm: Exception handling to leave and reenter guest mode.

2013-06-15 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:19PM -0700, David Daney wrote: > Currently this is a little complex, here are the facts about how it works: I'm not so much worried about the intrinic complexity of the job your code is trying to do rather than stackframe.h getting every more complex. We're reaching

[PATCH 15/31] mips/kvm: Exception handling to leave and reenter guest mode.

2013-06-07 Thread David Daney
From: David Daney Currently this is a little complex, here are the facts about how it works: o When running in Guest mode we set the high bit of CP0_XCONTEXT. If this bit is clear, we don't do anything special on an exception. o If we are in guest mode, upon an exception we: 1) load the s