Re: [PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-28 Thread Namhyung Kim
On Sun, Dec 28, 2014 at 1:33 AM, David Ahern wrote: > On 12/24/14 12:15 AM, Namhyung Kim wrote: >> >> @@ -61,12 +61,12 @@ static int unwind_entry(struct unwind_entry *entry, >> void *arg) >> __attribute__ ((noinline)) >> static int unwind_thread(struct thread *thread) >> { >> - struct

Re: [PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-28 Thread Namhyung Kim
On Sun, Dec 28, 2014 at 1:33 AM, David Ahern dsah...@gmail.com wrote: On 12/24/14 12:15 AM, Namhyung Kim wrote: @@ -61,12 +61,12 @@ static int unwind_entry(struct unwind_entry *entry, void *arg) __attribute__ ((noinline)) static int unwind_thread(struct thread *thread) { -

Re: [PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-27 Thread David Ahern
On 12/24/14 12:15 AM, Namhyung Kim wrote: @@ -61,12 +61,12 @@ static int unwind_entry(struct unwind_entry *entry, void *arg) __attribute__ ((noinline)) static int unwind_thread(struct thread *thread) { - struct perf_sample sample; + struct perf_sample sample = { +

Re: [PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-27 Thread David Ahern
On 12/24/14 12:15 AM, Namhyung Kim wrote: @@ -61,12 +61,12 @@ static int unwind_entry(struct unwind_entry *entry, void *arg) __attribute__ ((noinline)) static int unwind_thread(struct thread *thread) { - struct perf_sample sample; + struct perf_sample sample = { +

[PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-23 Thread Namhyung Kim
With multi-file data storage is enabled, it needs to search thread based on sample time since sample processing is done after other (task, comm and mmap) events are processed. This can be a problem if a session is very long and pid is recycled - in that case it'll only see the last one. So keep

[PATCH 15/37] perf tools: Introduce machine__find*_thread_time()

2014-12-23 Thread Namhyung Kim
With multi-file data storage is enabled, it needs to search thread based on sample time since sample processing is done after other (task, comm and mmap) events are processed. This can be a problem if a session is very long and pid is recycled - in that case it'll only see the last one. So keep