Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-24 Thread Nicolas Saenz Julienne
On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote: > On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote: > > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service) > > > > int32_t vchi_service_open(struct vchiq_instance *instance, > > struct

Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-24 Thread Dan Carpenter
On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote: > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service) > > int32_t vchi_service_open(struct vchiq_instance *instance, > struct service_creation *setup, > - struct vchi_service_handle

[PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-23 Thread Nicolas Saenz Julienne
The idea behind struct vchi_service_handle is to create an opaque handle to struct shim_service. This can be achieved by doing a forward declaration of struct shim_service, which will avoid unwarranted casts and pointer play. Ultimately as a rename is due all over the vchi user space, rename