Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
Signed-off-by: Pranith Kumar
---
net/rxrpc/ar-ack.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/ne
Pranith Kumar wrote:
>loop != call->acks_head || stop;
>loop = (loop + 1) & (call->acks_winsz - 1)
>) {
> - p_txb = call->acks_window + loop;
> - smp_read_barrier_depends();
> + p_txb = lockless_dereference(call)->acks_windo
Pranith Kumar wrote:
> Recently lockless_dereference() was added which can be used in place of
> hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
Actually, the use of smp_read_barrier_depends() is wrong in circular
buffering. See Documentation/circular-buffers.txt
On 11/13/2014 03:47 PM, David Howells wrote:
> Pranith Kumar wrote:
>
>> Recently lockless_dereference() was added which can be used in place of
>> hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
>
> Actually, the use of smp_read_barrier_depends() is wrong in circul
Pranith Kumar wrote:
> OK. Should I send in a patch removing these barriers then?
No. There need to be stronger barriers, at least in some of the cases.
circular-buffers.txt details what is required, but not all of the cases match
the pattern there, so it needs a bit more consideration.
David
5 matches
Mail list logo
