Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Ben Hutchings
On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > Driver wl1251 generating mac address randomly at startup and there is no way > to > set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs > file which can set permanent mac address by userspace helper program. Patch is

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Pali Rohár
On Monday 28 October 2013 16:29:21 Dan Williams wrote: > On Mon, 2013-10-28 at 16:04 +0100, Pali Rohár wrote: > > On Monday 28 October 2013 15:56:55 Johannes Berg wrote: > > > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > > > > If the device doesn't actually *have* a permanent MAC > > >

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Stephen Hemminger
On Mon, 28 Oct 2013 15:56:55 +0100 Johannes Berg wrote: > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > > > If the device doesn't actually *have* a permanent MAC address, then it > > shouldn't be returning one via ethtool, and should return an error for > > ETHTOOL_GPERMADDR. > > The

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Dan Williams
On Mon, 2013-10-28 at 16:04 +0100, Pali Rohár wrote: > On Monday 28 October 2013 15:56:55 Johannes Berg wrote: > > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > > > If the device doesn't actually *have* a permanent MAC > > > address, then it shouldn't be returning one via ethtool, > > >

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Pali Rohár
On Monday 28 October 2013 15:56:55 Johannes Berg wrote: > On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > > If the device doesn't actually *have* a permanent MAC > > address, then it shouldn't be returning one via ethtool, > > and should return an error for ETHTOOL_GPERMADDR. > > There's

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Johannes Berg
On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote: > If the device doesn't actually *have* a permanent MAC address, then it > shouldn't be returning one via ethtool, and should return an error for > ETHTOOL_GPERMADDR. There's currently no provision for that, but I agree it would be better to

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Dan Williams
On Mon, 2013-10-28 at 15:00 +0100, Pali Rohár wrote: > On Monday 28 October 2013 14:55:22 Johannes Berg wrote: > > On Mon, 2013-10-28 at 14:49 +0100, Pali Rohár wrote: > > > On Monday 28 October 2013 14:45:05 Johannes Berg wrote: > > > > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > > > >

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Pali Rohár
On Monday 28 October 2013 14:55:22 Johannes Berg wrote: > On Mon, 2013-10-28 at 14:49 +0100, Pali Rohár wrote: > > On Monday 28 October 2013 14:45:05 Johannes Berg wrote: > > > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > > > > Driver wl1251 generating mac address randomly at startup > >

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Johannes Berg
On Mon, 2013-10-28 at 14:49 +0100, Pali Rohár wrote: > On Monday 28 October 2013 14:45:05 Johannes Berg wrote: > > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > > > Driver wl1251 generating mac address randomly at startup and > > > there is no way to set permanent mac address via > > > SET

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Pali Rohár
On Monday 28 October 2013 14:45:05 Johannes Berg wrote: > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > > Driver wl1251 generating mac address randomly at startup and > > there is no way to set permanent mac address via > > SET_IEEE80211_PERM_ADDR. This patch export sysfs file which > > ca

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-28 Thread Johannes Berg
On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > Driver wl1251 generating mac address randomly at startup and there is no way > to > set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs > file which can set permanent mac address by userspace helper program. Patch is

[PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

2013-10-26 Thread Pali Rohár
Driver wl1251 generating mac address randomly at startup and there is no way to set permanent mac address via SET_IEEE80211_PERM_ADDR. This patch export sysfs file which can set permanent mac address by userspace helper program. Patch is needed for devices which do not store mac address in internal