Re: [PATCH 16/19] EDAC, ghes: Fix grain calculation

2019-10-11 Thread Mauro Carvalho Chehab
Em Thu, 10 Oct 2019 20:25:37 + Robert Richter escreveu: > The current code to convert a physical address mask to a grain > (defined as granularity in bytes) is: > > e->grain = ~(mem_err->physical_addr_mask & ~PAGE_MASK); > > This is broken in several ways: > > 1) It calculates to wro

[PATCH 16/19] EDAC, ghes: Fix grain calculation

2019-10-10 Thread Robert Richter
The current code to convert a physical address mask to a grain (defined as granularity in bytes) is: e->grain = ~(mem_err->physical_addr_mask & ~PAGE_MASK); This is broken in several ways: 1) It calculates to wrong grain values. E.g., a physical address mask of ~0xfff should give a grain