Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 01:47:01AM +0530, kajoljain escreveu: > > > On 7/28/20 10:56 PM, Ian Rogers wrote: > > On Tue, Jul 28, 2020 at 5:36 AM Arnaldo Carvalho de Melo > > wrote: > >> > >> Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: > >>> So far compute_single function relies o

[PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-29 Thread Jiri Olsa
So far compute_single function relies on the fact, that there's only single metric defined within evlist in all tests. In following patch we will add test for metric group, so we need to be able to compute metric by given name. Adding the name argument to compute_single and iterating evlist and ev

Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-28 Thread kajoljain
On 7/28/20 10:56 PM, Ian Rogers wrote: > On Tue, Jul 28, 2020 at 5:36 AM Arnaldo Carvalho de Melo > wrote: >> >> Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: >>> So far compute_single function relies on the fact, that >>> there's only single metric defined within evlist in all

Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-28 Thread Ian Rogers
On Tue, Jul 28, 2020 at 5:36 AM Arnaldo Carvalho de Melo wrote: > > Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: > > So far compute_single function relies on the fact, that > > there's only single metric defined within evlist in all > > tests. In following patch we will add test f

Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: > So far compute_single function relies on the fact, that > there's only single metric defined within evlist in all > tests. In following patch we will add test for metric > group, so we need to be able to compute metric by given > name.

[PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-19 Thread Jiri Olsa
So far compute_single function relies on the fact, that there's only single metric defined within evlist in all tests. In following patch we will add test for metric group, so we need to be able to compute metric by given name. Adding the name argument to compute_single and iterating evlist and ev