Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 8:50 AM, David Howells wrote: > Andy Lutomirski wrote: > >> > You can also fudge the signature (or a hash) by adding extra data to or >> > modifying the data blob and by switching signature values between signature >> > blobs. >> >> So there's another design error in

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-06-01 Thread David Howells
Andy Lutomirski wrote: > > You can also fudge the signature (or a hash) by adding extra data to or > > modifying the data blob and by switching signature values between signature > > blobs. > > So there's another design error in PKCS#7? Great! No. This applies to *all* signatures where

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-06-01 Thread David Howells
Andy Lutomirski l...@amacapital.net wrote: You can also fudge the signature (or a hash) by adding extra data to or modifying the data blob and by switching signature values between signature blobs. So there's another design error in PKCS#7? Great! No. This applies to *all* signatures

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 8:50 AM, David Howells dhowe...@redhat.com wrote: Andy Lutomirski l...@amacapital.net wrote: You can also fudge the signature (or a hash) by adding extra data to or modifying the data blob and by switching signature values between signature blobs. So there's

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread Andy Lutomirski
On Fri, May 29, 2015 at 5:40 AM, David Howells wrote: > Andy Lutomirski wrote: > >> This is insecure because PKCS#7 authenticated attributes are broken (see >> RFC2315 section 9.4 note 4). You need to either require that everything have >> authenticated attributes or require that nothing have

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread David Howells
Andy Lutomirski wrote: > This is insecure because PKCS#7 authenticated attributes are broken (see > RFC2315 section 9.4 note 4). You need to either require that everything have > authenticated attributes or require that nothing have authenticated > attributes. Maybe this insecurity doesn't

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread David Howells
Andy Lutomirski l...@kernel.org wrote: This is insecure because PKCS#7 authenticated attributes are broken (see RFC2315 section 9.4 note 4). You need to either require that everything have authenticated attributes or require that nothing have authenticated attributes. Maybe this insecurity

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-29 Thread Andy Lutomirski
On Fri, May 29, 2015 at 5:40 AM, David Howells dhowe...@redhat.com wrote: Andy Lutomirski l...@kernel.org wrote: This is insecure because PKCS#7 authenticated attributes are broken (see RFC2315 section 9.4 note 4). You need to either require that everything have authenticated attributes or

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-28 Thread Andy Lutomirski
[resending with further gmane screwups fixed] On 05/28/2015 08:48 AM, David Howells wrote: Modify the sign-file program to take a "-F " parameter. The name is a utf8 string that, if given, is inserted in a PKCS#7 authenticated attribute from where it can be extracted by the kernel.

[PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-28 Thread David Howells
Modify the sign-file program to take a "-F " parameter. The name is a utf8 string that, if given, is inserted in a PKCS#7 authenticated attribute from where it can be extracted by the kernel. Authenticated attributes are added to the signature digest. If the attribute is present, the signature

Re: [PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-28 Thread Andy Lutomirski
[resending with further gmane screwups fixed] On 05/28/2015 08:48 AM, David Howells wrote: Modify the sign-file program to take a -F firmware name parameter. The name is a utf8 string that, if given, is inserted in a PKCS#7 authenticated attribute from where it can be extracted by the kernel.

[PATCH 16/20] PKCS#7: Add an optional authenticated attribute to hold firmware name [ver #5]

2015-05-28 Thread David Howells
Modify the sign-file program to take a -F firmware name parameter. The name is a utf8 string that, if given, is inserted in a PKCS#7 authenticated attribute from where it can be extracted by the kernel. Authenticated attributes are added to the signature digest. If the attribute is present, the